Skip to content

s390x SIGP fixes

Eric Farman kvm linux-s390 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 8 repliesIn review
  2. v16 patches 22 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1-2: Applied r-b from Claudio, Janosch, and Nico (thank you!)
- [JF] Patch 3: Clarified commit message that it's dealing with semantics rather than a bugfix.
- [NB] Patch 4-5: Added return code checks of the _nowait() routines (Claudio: I appreciate the r-b on 4, but didn't apply it because of the new checks that were made here)
- [EF] Patch 4-5: Use the non-retry sigp() call directly, rather than smp_sigp()
v1: https://lore.kernel.org/r/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6lib: s390x: smp: Retry SIGP SENSE on CC2lib/s390x/smp.c+1 -11 reply
2/6s390x: smp: Test SIGP RESTART against stopped CPUs390x/smp.c+2 -61 reply
3/6s390x: smp: Fix checks for SIGP STOP STORE STATUSs390x/smp.c+2 -12 replies
4/6s390x: smp: Create and use a non-waiting CPU stoplib/s390x/smp.c lib/s390x/smp.h s390x/smp.c+37 -81 reply
5/6s390x: smp: Create and use a non-waiting CPU restartlib/s390x/smp.c lib/s390x/smp.h s390x/smp.c+43 -32 replies
6/6lib: s390x: smp: Remove smp_sigp_retrylib/s390x/smp.c lib/s390x/smp.h s390x/smp.c+6 -131 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJanosch FrankNico BoehrClaudio ImbrendaThomas Huth
1/6R-b R-b R-b R-b
2/6R-b R-b R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH kvm-unit-tests v2 0/6] s390x SIGP fixes

Hi all,

Here is a second version of the SIGNAL PROCESSOR tests, addressing the comments that were made to v1.

The biggest change is Patch 6, which has effectively been replaced. Considering comments from Nico and Janosch, and making sure consumers of smp_sigp get their SIGP retried, I opted to convert smp_sigp() to perform the CC2 retry under the covers, and remove smp_sigp_retry() itself. This effectively reverts patch 1, but I thought the end result was cleaner and less prone to confusion going forward. If a test needs a no-retry interface going forward, that would be one thing, but the only places that do that are the testing of STOP and RESTART itself, which handle this as seen in patches 4 and 5.

So, thoughts?

v2:
- Patch 1-2: Applied r-b from Claudio, Janosch, and Nico (thank you!)
- [JF] Patch 3: Clarified commit message that it's dealing with semantics rather than a bugfix.
- [NB] Patch 4-5: Added return code checks of the _nowait() routines (Claudio: I appreciate the r-b on 4, but didn't apply it because of the new checks that were made here)
- [EF] Patch 4-5: Use the non-retry sigp() call directly, rather than smp_sigp()
v1: https://lore.kernel.org/r/[email protected]/

Eric Farman (6):
lib: s390x: smp: Retry SIGP SENSE on CC2
s390x: smp: Test SIGP RESTART against stopped CPU
s390x: smp: Fix checks for SIGP STOP STORE STATUS
s390x: smp: Create and use a non-waiting CPU stop
s390x: smp: Create and use a non-waiting CPU restart
lib: s390x: smp: Remove smp_sigp_retry

 lib/s390x/smp.c | 63 ++++++++++++++++++++++++++++++++++++++++++-------
 lib/s390x/smp.h |  3 ++-
 s390x/smp.c     | 53 +++++++++++++++++++++++++----------------
 3 files changed, 89 insertions(+), 30 deletions(-)
Signature · 1 line
2.32.0