softmmu: move and refactor -runas, -chroot and -daemonize
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 5 repliesIn review
- v14 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- Fix mistake that left stderr open when daemonizing
- Remove use of is_daemonized from chardev
- Remove use of is_daemonized from logging
- Eliminate is_daemonized function
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | softmmu: remove deprecated --enable-fips optiondocs/ docs/ include/ +4 more | +11 | 0 replies | |
| 2/8 | os-posix: refactor code handling the -runas argumentos-posix.c | +39 | 0 replies | |
| 3/8 | os-posix: refactor code handling the -chroot argumentos-posix.c | +11 | 0 replies | |
| 4/8 | util: remove use of is_daemonized flag from logging codeinclude/ softmmu/ util/ | +13 | 1 reply | |
| 5/8 | softmmu: refactor use of is_daemonized() methodsoftmmu/ | +7 | 1 reply | |
| 6/8 | chardev: add API to block use of the stdio implementationchardev/ include/ softmmu/ | +41 | 1 reply | |
| 7/8 | softmmu: move parsing of -runas, -chroot and -daemonize codeinclude/ include/ os-posix.c +2 more | +117 | 1 reply | |
| 8/8 | softmmu: remove is_daemonized() methodinclude/ include/ os-posix.c +2 more | +0 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Philippe Mathieu-Daudé |
|---|---|---|
| 1/8 | R-b | |
| 2/8 | R-b | |
| 3/8 | R-b | |
| 4/8 | R-b | |
| 5/8 | R-b | |
| 6/8 | R-b | |
| 7/8 | R-b | |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize
This small series was motivated by my thoughts on the proposals in
https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg01135.html
It demonstrates the approach I mention there, and has the further benefit of untangling and isolating the implementation of UID changing, chrooting and daemonizing, from the parsing of the corresponding command line options.
Changed in v2:
- Fix mistake that left stderr open when daemonizing
- Remove use of is_daemonized from chardev
- Remove use of is_daemonized from logging
- Eliminate is_daemonized function
Daniel P. Berrangé (8):
softmmu: remove deprecated --enable-fips option
os-posix: refactor code handling the -runas argument
os-posix: refactor code handling the -chroot argument
util: remove use of is_daemonized flag from logging code
softmmu: refactor use of is_daemonized() method
chardev: add API to block use of the stdio implementation
softmmu: move parsing of -runas, -chroot and -daemonize code
softmmu: remove is_daemonized() method
chardev/char-stdio.c | 12 +- docs/about/deprecated.rst | 12 -- docs/about/removed-features.rst | 11 ++ include/chardev/char-stdio.h | 29 ++++ include/qemu/log.h | 1 + include/qemu/osdep.h | 3 - include/sysemu/os-posix.h | 6 +- include/sysemu/os-win32.h | 6 - os-posix.c | 227 ++++++++++---------------------- os-win32.c | 9 -- qemu-options.hx | 10 -- softmmu/vl.c | 92 +++++++++++-- stubs/is-daemonized.c | 9 -- stubs/meson.build | 1 - ui/vnc.c | 7 - util/log.c | 12 +- util/osdep.c | 28 ---- 17 files changed, 213 insertions(+), 262 deletions(-) create mode 100644 include/chardev/char-stdio.h delete mode 100644 stubs/is-daemonized.c
Signature · 1 line
2.34.1