Skip to content

cocoa: keyboard quality of life

Akihiko Odaki qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Removed extra cast operator (BALATON Zoltan)
- Renamed swap-option-command to swap-opt-cmd (BALATON Zoltan)
- Simplified swap-opt-cmd flag setting
- Updated qapi/ui.json for 7.0

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ui/cocoa: capture all keys and combos when mouse is grabbedqapi/ui.json qemu-options.hx ui/cocoa.m+83 -11 reply
2/2ui/cocoa: add option to swap Option and Commandqapi/ui.json qemu-options.hx ui/cocoa.m+45 -101 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMarkus Armbruster
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] cocoa: keyboard quality of life

The patch series was originally posted by Gustavo Noronha Silva, and rebased to commit 2acf5e1d0e0f15be1b0ad85cf05b3a6e6307680c by Akihiko Odaki.

This series adds two new options to the cocoa display:

- full-grab causes it to use a global tap to steal system combos away from Mac OS X, so they can be handled by the VM

- swap-opt-cmd does what it says on the tin; while that is something you can do at the Mac OS X level or even supported by some keyboards, it is much more convenient to have qemu put Meta/Super and Alt where they belong if you are running a non-Mac VM

Both are off by default. For full-grab in particular, it is off also because unfortunately it needs accessibility permissions for input grabbing, so it requires more deliberate action by the user anyway.

v2:
- Removed extra cast operator (BALATON Zoltan)
- Renamed swap-option-command to swap-opt-cmd (BALATON Zoltan)
- Simplified swap-opt-cmd flag setting
- Updated qapi/ui.json for 7.0

Gustavo Noronha Silva (2):
ui/cocoa: capture all keys and combos when mouse is grabbed ui/cocoa: add option to swap Option and Command

 qapi/ui.json    |  21 +++++++++
 qemu-options.hx |   3 ++
 ui/cocoa.m      | 111 ++++++++++++++++++++++++++++++++++++++++++++----
 3 files changed, 126 insertions(+), 9 deletions(-)
Signature · 1 line
2.32.0 (Apple Git-132)