Skip to content

drm/gma500: Various cleanups to GEM code

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest12 patches 4 repliesIn review
  2. v110 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* put common code in psb_gtt_{init,fini,resume}() into helpers (Sam, Patrik)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/gma500: Remove struct psb_gem_object.npagedrivers/gpu/drm/gma500/gem.c drivers/gpu/drm/gma500/gem.h drivers/gpu/drm/gma500/gma_display.c+8 -100 replies
2/12drm/gma500: Acquire reservation lock for GEM objectsdrivers/gpu/drm/gma500/gem.c+12 -00 replies
3/12drm/gma500: Move GTT locking into GTT helpersdrivers/gpu/drm/gma500/gem.c drivers/gpu/drm/gma500/gtt.c+13 -220 replies
4/12drm/gma500: Remove struct psb_gtt.sem sempahoredrivers/gpu/drm/gma500/gtt.c drivers/gpu/drm/gma500/gtt.h drivers/gpu/drm/gma500/psb_drv.c+0 -120 replies
5/12drm/gma500: Move GTT setup and restoration into helper funtionsdrivers/gpu/drm/gma500/gtt.c+68 -470 replies
6/12drm/gma500: Move GTT resume logic out of psb_gtt_init()drivers/gpu/drm/gma500/gtt.c drivers/gpu/drm/gma500/gtt.h drivers/gpu/drm/gma500/psb_drv.c+104 -220 replies
7/12drm/gma500: Cleanup GTT uninit and error handlingdrivers/gpu/drm/gma500/gtt.c drivers/gpu/drm/gma500/gtt.h drivers/gpu/drm/gma500/psb_drv.c +1 more+27 -270 replies
8/12drm/gma500: Split GTT init/resume/fini into GTT and GEM functionsdrivers/gpu/drm/gma500/gtt.c drivers/gpu/drm/gma500/gtt.h drivers/gpu/drm/gma500/psb_drv.c+83 -420 replies
9/12drm/gma500: Inline psb_gtt_restore()drivers/gpu/drm/gma500/gtt.c drivers/gpu/drm/gma500/gtt.h drivers/gpu/drm/gma500/power.c+7 -150 replies
10/12drm/gma500: Move GEM memory management functions to gem.cdrivers/gpu/drm/gma500/gem.c drivers/gpu/drm/gma500/gem.h drivers/gpu/drm/gma500/gtt.c +3 more+149 -1300 replies
11/12drm/gma500: Move GTT enable and disable code into helpersdrivers/gpu/drm/gma500/gtt.c+46 -351 reply
12/12drm/gma500: Move GTT memory-range setup into helperdrivers/gpu/drm/gma500/gtt.c+64 -891 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchPatrik Jakobsson
1/12A-b
2/12A-b
3/12A-b
4/12A-b
5/12A-b
6/12A-b
7/12A-b
8/12A-b
9/12A-b
10/12A-b
11/12A-b
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] drm/gma500: Various cleanups to GEM code

Refactor and simplify various parts of the memory management. This includes locking, initialization and finalizer functions, and code organization.

Tested on Atom N2800 hardware.

v2:
* put common code in psb_gtt_{init,fini,resume}() into helpers (Sam, Patrik)

Thomas Zimmermann (12):
drm/gma500: Remove struct psb_gem_object.npage drm/gma500: Acquire reservation lock for GEM objects drm/gma500: Move GTT locking into GTT helpers drm/gma500: Remove struct psb_gtt.sem sempahore drm/gma500: Move GTT setup and restoration into helper funtions drm/gma500: Move GTT resume logic out of psb_gtt_init() drm/gma500: Cleanup GTT uninit and error handling drm/gma500: Split GTT init/resume/fini into GTT and GEM functions drm/gma500: Inline psb_gtt_restore()
drm/gma500: Move GEM memory management functions to gem.c drm/gma500: Move GTT enable and disable code into helpers drm/gma500: Move GTT memory-range setup into helper

 drivers/gpu/drm/gma500/gem.c         | 161 ++++++++++++++-
 drivers/gpu/drm/gma500/gem.h         |  13 +-
 drivers/gpu/drm/gma500/gma_display.c |   8 +-
 drivers/gpu/drm/gma500/gtt.c         | 295 +++++++++++++--------------
 drivers/gpu/drm/gma500/gtt.h         |   8 +-
 drivers/gpu/drm/gma500/power.c       |   5 +-
 drivers/gpu/drm/gma500/psb_drv.c     |  13 +-
 drivers/gpu/drm/gma500/psb_drv.h     |   1 -
 8 files changed, 317 insertions(+), 187 deletions(-)

base-commit: 710a019ad85e96e66f7d75ee7f4733cdd8a2b0d0
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 6e1032c6302461624f33194c8b8f37103a3fa6ef

Signature · 1 line
2.35.1