Skip to content

host: Support macOS 12

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v7 Latest22 patches 25 repliesIn review

Changes in v7 from the cover letter

- Dropped merged patches
- Addressed Akihiko Odaki comments (squashed 2 patches, added R/T-b)
- Dropped 'configure: Disable out-of-line atomic operations on Aarch64'
- Add few macos patches on the list pending for 7.0 so tested by CI

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22configure: Allow passing extra Objective C compiler flagsconfigure meson.build+13 -00 replies
2/22tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directivestests/fp/meson.build+5 -01 reply
3/22hvf: Use standard CR0 and CR4 register definitionstarget/i386/hvf/vmx.h target/i386/hvf/x86.c target/i386/hvf/x86.h +2 more+15 -470 replies
4/22hvf: Make hvf_get_segments() / hvf_put_segments() localtarget/i386/hvf/x86hvf.c target/i386/hvf/x86hvf.h+2 -40 replies
5/22hvf: Remove deprecated hv_vcpu_flush() callstarget/i386/hvf/vmx.h target/i386/hvf/x86_task.c target/i386/hvf/x86hvf.c+0 -50 replies
6/22hvf: Fix OOB write in RDTSCP instruction decodetarget/i386/hvf/x86_decode.c target/i386/hvf/x86hvf.c target/i386/hvf/x86hvf.h+19 -23 replies
7/22block/file-posix: Remove a deprecation warning on macOS 12block/file-posix.c+10 -40 replies
8/22audio/coreaudio: Remove a deprecation warning on macOS 12audio/coreaudio.c+11 -60 replies
9/22audio/dbus: Fix building with modules on macOSaudio/meson.build+1 -10 replies
10/22audio: Log context for audio bugaudio/audio.c audio/audio_template.h+24 -280 replies
11/22coreaudio: Always return 0 in handle_voice_changeaudio/coreaudio.c+2 -40 replies
12/22audio: Rename coreaudio extension to use Objective-C compileraudio/coreaudio.m audio/meson.build+1 -10 replies
13/22osdep: Avoid using Clang-specific __builtin_available()include/qemu/osdep.h+3 -71 reply
14/22meson: Resolve the entitlement.sh script once for goodmeson.build+4 -11 reply
15/22meson: Log QEMU_CXXFLAGS content in summarymeson.build+1 -01 reply
16/22configure: Pass filtered QEMU_OBJCFLAGS to mesonconfigure meson.build+28 -11 reply
17/22ui/cocoa: Constify qkeycode translation arraysui/cocoa.m+2 -21 reply
18/22ui/cocoa: add option to disable left-command forwarding to guestqapi/ui.json qemu-options.hx ui/cocoa.m+37 -10 replies
19/22ui/cocoa: release mouse when user switches away from QEMU windowui/cocoa.m+2 -00 replies
20/22ui/cocoa: capture all keys and combos when mouse is grabbedqapi/ui.json qemu-options.hx ui/cocoa.m+74 -21 reply
21/22ui/cocoa: add option to swap Option and Commandqapi/ui.json qemu-options.hx ui/cocoa.m+46 -121 reply
22/22gitlab-ci: Support macOS 12 via cirrus-run.gitlab-ci.d/cirrus.yml .gitlab-ci.d/cirrus/macos-12.vars tests/lcitool/refresh+33 -010 replies

Reviews trailers per patch

21 of 22 patches have a Reviewed-by or Acked-by.

PatchAkihiko OdakiPhilippe Mathieu-DaudéRoman BolshakovChristian SchoenebeckLi ZhangMarkus ArmbrusterPaolo BonziniDaniel P. BerrangéAlex Bennée
1/22R-b T-b
2/22R-b T-b A-b
3/22R-b
4/22R-b T-b
5/22R-b T-b
6/22
7/22R-b T-b R-b
8/22R-b T-b R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b
13/22R-b T-b
14/22R-b T-b
15/22R-b T-b
16/22R-b T-b A-b
17/22R-b T-b
18/22R-b
19/22R-b
20/22A-b
21/22A-b
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/22] host: Support macOS 12

From: Philippe Mathieu-Daudé <[email protected]>

Few patches to be able to build QEMU on macOS 12 (Monterey).

Missing review:
0006-hvf-Fix-OOB-write-in-RDTSCP-instruction-decode.patch 0013-osdep-Avoid-using-Clang-specific-__builtin_available.patch 0014-meson-Resolve-the-entitlement.sh-script-once-for-goo.patch 0015-meson-Log-QEMU_CXXFLAGS-content-in-summary.patch 0016-configure-Pass-filtered-QEMU_OBJCFLAGS-to-meson.patch 0017-ui-cocoa-Constify-qkeycode-translation-arrays.patch 0020-ui-cocoa-capture-all-keys-and-combos-when-mouse-is-g.patch 0021-ui-cocoa-add-option-to-swap-Option-and-Command.patch 0022-gitlab-ci-Support-macOS-12-via-cirrus-run.patch

Since v6:
- Dropped merged patches
- Addressed Akihiko Odaki comments (squashed 2 patches, added R/T-b)
- Dropped 'configure: Disable out-of-line atomic operations on Aarch64'
- Add few macos patches on the list pending for 7.0 so tested by CI

Since v5:
- Fixed failed rebase between patches 10 and 16 (Akihiko)
- Include "ui/cocoa: Fix the leak of qemu_console_get_label"

Since v4:
- Use MAC_OS_X_VERSION_MIN_REQUIRED definition (Akihiko)
- Include patches from Akihiko

Since v3:
- Fix --enable-modules
- Ignore #pragma on softfloat3 tests
- Addressed Akihiko Odaki comments
- Include Cameron Esfahani patches

Since v2:
- Addressed Akihiko Odaki comments:
. use __is_identifier(),
. remove cocoa setAllowedFileTypes()
- Addressed Daniel Berrangé comment:
. rebased on testing/next, update libvirt-ci/lcitool

Akihiko Odaki (2):
audio: Log context for audio bug
coreaudio: Always return 0 in handle_voice_change

Cameron Esfahani (2):
hvf: Use standard CR0 and CR4 register definitions
hvf: Fix OOB write in RDTSCP instruction decode

Carwyn Ellis (2):
ui/cocoa: add option to disable left-command forwarding to guest ui/cocoa: release mouse when user switches away from QEMU window

Gustavo Noronha Silva (2):
ui/cocoa: capture all keys and combos when mouse is grabbed ui/cocoa: add option to swap Option and Command

Philippe Mathieu-Daudé (14):
configure: Allow passing extra Objective C compiler flags tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives
hvf: Make hvf_get_segments() / hvf_put_segments() local
hvf: Remove deprecated hv_vcpu_flush() calls block/file-posix: Remove a deprecation warning on macOS 12 audio/coreaudio: Remove a deprecation warning on macOS 12 audio/dbus: Fix building with modules on macOS
audio: Rename coreaudio extension to use Objective-C compiler
osdep: Avoid using Clang-specific __builtin_available()
meson: Resolve the entitlement.sh script once for good
meson: Log QEMU_CXXFLAGS content in summary
configure: Pass filtered QEMU_OBJCFLAGS to meson ui/cocoa: Constify qkeycode translation arrays
gitlab-ci: Support macOS 12 via cirrus-run

 .gitlab-ci.d/cirrus.yml            |  16 ++++
 .gitlab-ci.d/cirrus/macos-12.vars  |  16 ++++
 audio/audio.c                      |  25 +++---
 audio/audio_template.h             |  27 +++----
 audio/{coreaudio.c => coreaudio.m} |  23 +++---
 audio/meson.build                  |   4 +-
 block/file-posix.c                 |  14 +++-
 configure                          |  31 ++++++++
 include/qemu/osdep.h               |  10 +--
 meson.build                        |  17 +++-
 qapi/ui.json                       |  29 +++++++
 qemu-options.hx                    |  15 ++++
 target/i386/hvf/vmx.h              |  19 +++--
 target/i386/hvf/x86.c              |   6 +-
 target/i386/hvf/x86.h              |  34 --------
 target/i386/hvf/x86_decode.c       |  12 ++-
 target/i386/hvf/x86_mmu.c          |   2 +-
 target/i386/hvf/x86_task.c         |   4 +-
 target/i386/hvf/x86hvf.c           |  14 +++-
 target/i386/hvf/x86hvf.h           |   3 +-
 tests/fp/meson.build               |   5 ++
 tests/lcitool/refresh              |   1 +
 ui/cocoa.m                         | 122 ++++++++++++++++++++++++++---
 23 files changed, 327 insertions(+), 122 deletions(-)
 create mode 100644 .gitlab-ci.d/cirrus/macos-12.vars
 rename audio/{coreaudio.c => coreaudio.m} (97%)
Signature · 1 line
2.34.1