Skip to content

RFC net: phy: lan87xx: use genphy_read_master_slave function

Arun Ramadoss lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: phy: exported the genphy_read_master_slave functiondrivers/net/phy/phy_device.c include/linux/phy.h+11 -101 reply
2/2net: phy: lan87xx: use genphy_read_master_slave in read_statusdrivers/net/phy/microchip_t1.c+1 -291 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/2] net: phy: lan87xx: use genphy_read_master_slave function

LAN87xx T1 Phy has the same register field as gigabit phy for reading the master slave configuration. But the genphy_read_master_slave function has a check of gigabit phy. So refactored the function in such a way, moved the speed check to the genphy_read_status function. Analyzed the nxp-tja11xx function for refactoring, but the register for configuring master/slave is nxp specific which is not extended phy register.
And analyzed the reusing genphy_setup_master_slave, but for LAN87xx MASTER_ENABLE is always 1 and Preferred state is always 0. So, I didn't try to change it.

Arun Ramadoss (2):
net: phy: exported the genphy_read_master_slave function
net: phy: lan87xx: use genphy_read_master_slave in read_status

 drivers/net/phy/microchip_t1.c | 30 +-----------------------------
 drivers/net/phy/phy_device.c   | 20 ++++++++++----------
 include/linux/phy.h            |  1 +
 3 files changed, 12 insertions(+), 39 deletions(-)

base-commit: 669b258a793db9f1c3bff29ce2bbd61b810503ad

Signature · 1 line
2.33.0