Skip to content

RFC KVM: x86: hyper-v: Fine-grained TLB flush + Direct TLB flush feature

Vitaly Kuznetsov kvm linux-hyperv lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest19 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19KVM: x86: hyper-v: Resurrect dedicated KVM_REQ_HV_TLB_FLUSH flagarch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c arch/x86/kvm/x86.c+10 -30 replies
2/19KVM: x86: hyper-v: Introduce TLB flush ringarch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c arch/x86/kvm/hyperv.h +2 more+108 -30 replies
3/19KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls gentlyarch/x86/kvm/hyperv.c+121 -200 replies
4/19KVM: x86: hyper-v: Expose support for extended gva ranges for flush hypercallsarch/x86/include/asm/hyperv-tlfs.h arch/x86/kvm/hyperv.c+3 -00 replies
5/19KVM: x86: Prepare kvm_hv_flush_tlb() to handle L2's GPAsarch/x86/kvm/hyperv.c+7 -00 replies
6/19KVM: x86: hyper-v: Don't use sparse_set_to_vcpu_mask() in kvm_hv_send_ipi()arch/x86/kvm/hyperv.c+24 -110 replies
7/19KVM: x86: hyper-v: Create a separate ring for Direct TLB flusharch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c arch/x86/kvm/hyperv.h+20 -70 replies
8/19KVM: x86: hyper-v: Use preallocated buffer in 'struct kvm_vcpu_hv' instead of on-stack 'sparse_banks'arch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c+7 -20 replies
9/19KVM: nVMX: Keep track of hv_vm_id/hv_vp_id when eVMCS is in usearch/x86/include/asm/kvm_host.h arch/x86/kvm/vmx/nested.c+26 -40 replies
10/19KVM: nSVM: Keep track of Hyper-V hv_vm_id/hv_vp_idarch/x86/kvm/svm/hyperv.h arch/x86/kvm/svm/nested.c+17 -00 replies
11/19KVM: x86: Introduce .post_hv_direct_flush() nested hookarch/x86/include/asm/kvm_host.h arch/x86/kvm/Makefile arch/x86/kvm/svm/hyperv.c +5 more+23 -10 replies
12/19KVM: x86: hyper-v: Introduce kvm_hv_is_tlb_flush_hcall()arch/x86/kvm/hyperv.h+24 -00 replies
13/19KVM: x86: hyper-v: Direct TLB flusharch/x86/kvm/hyperv.c arch/x86/kvm/trace.h+68 -180 replies
14/19KVM: x86: hyper-v: Introduce fast kvm_hv_direct_tlb_flush_exposed() checkarch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c arch/x86/kvm/hyperv.h+14 -00 replies
15/19x86/hyperv: Fix 'struct hv_enlightened_vmcs' definitionarch/x86/include/asm/hyperv-tlfs.h+2 -21 reply
16/19KVM: nVMX: hyper-v: Direct TLB flusharch/x86/kvm/vmx/evmcs.c arch/x86/kvm/vmx/evmcs.h arch/x86/kvm/vmx/nested.c+39 -00 replies
17/19KVM: x86: KVM_REQ_TLB_FLUSH_CURRENT is a superset of KVM_REQ_HV_TLB_FLUSH tooarch/x86/kvm/x86.c+4 -10 replies
18/19KVM: nSVM: hyper-v: Direct TLB flusharch/x86/kvm/svm/hyperv.c arch/x86/kvm/svm/hyperv.h arch/x86/kvm/svm/nested.c+48 -10 replies
19/19KVM: x86: Expose Hyper-V Direct TLB flush featurearch/x86/kvm/hyperv.c+1 -00 replies

Reviews trailers per patch

1 of 19 patches has a Reviewed-by or Acked-by.

PatchMichael Kelley
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19R-b
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 00/19] KVM: x86: hyper-v: Fine-grained TLB flush + Direct TLB flush feature

Currently, KVM handles HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} requests by flushing the whole VPID and this is sub-optimal. This series introduces the required mechanism to make handling of these requests more fine-grained by flushing individual GVAs only (when requested). On this foundation, "Direct Virtual Flush" Hyper-V feature is implemented. The feature allows L0 to handle Hyper-V TLB flush hypercalls directly at L0 without the need to reflect the exit to L1. This has at least two
benefits: reflecting vmexit and the consequent vmenter are avoided + L0 has precise information whether the target vCPU is actually running (and thus requires a kick).

RFC part:
- The series is poorly tested. I've only smoke-tested WS2019 and Win11+WSL2 on VMX and AMD harware to the point that no immediate issues are observed on boot. We certainly need something added to selftests/kvm-unit-tests.

Vitaly Kuznetsov (19):
KVM: x86: hyper-v: Resurrect dedicated KVM_REQ_HV_TLB_FLUSH flag
KVM: x86: hyper-v: Introduce TLB flush ring
KVM: x86: hyper-v: Handle HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST{,EX} calls
gently
KVM: x86: hyper-v: Expose support for extended gva ranges for flush
hypercalls
KVM: x86: Prepare kvm_hv_flush_tlb() to handle L2's GPAs
KVM: x86: hyper-v: Don't use sparse_set_to_vcpu_mask() in

    kvm_hv_send_ipi()

KVM: x86: hyper-v: Create a separate ring for Direct TLB flush
KVM: x86: hyper-v: Use preallocated buffer in 'struct kvm_vcpu_hv'
instead of on-stack 'sparse_banks'
KVM: nVMX: Keep track of hv_vm_id/hv_vp_id when eVMCS is in use
KVM: nSVM: Keep track of Hyper-V hv_vm_id/hv_vp_id
KVM: x86: Introduce .post_hv_direct_flush() nested hook
KVM: x86: hyper-v: Introduce kvm_hv_is_tlb_flush_hcall()
KVM: x86: hyper-v: Direct TLB flush
KVM: x86: hyper-v: Introduce fast kvm_hv_direct_tlb_flush_exposed()
check
x86/hyperv: Fix 'struct hv_enlightened_vmcs' definition
KVM: nVMX: hyper-v: Direct TLB flush
KVM: x86: KVM_REQ_TLB_FLUSH_CURRENT is a superset of
KVM_REQ_HV_TLB_FLUSH too
KVM: nSVM: hyper-v: Direct TLB flush
KVM: x86: Expose Hyper-V Direct TLB flush feature

 arch/x86/include/asm/hyperv-tlfs.h |   6 +-
 arch/x86/include/asm/kvm_host.h    |  30 +++
 arch/x86/kvm/Makefile              |   3 +-
 arch/x86/kvm/hyperv.c              | 305 ++++++++++++++++++++++++++---
 arch/x86/kvm/hyperv.h              |  55 ++++++
 arch/x86/kvm/svm/hyperv.c          |  18 ++
 arch/x86/kvm/svm/hyperv.h          |  37 ++++
 arch/x86/kvm/svm/nested.c          |  25 ++-
 arch/x86/kvm/trace.h               |  21 +-
 arch/x86/kvm/vmx/evmcs.c           |  24 +++
 arch/x86/kvm/vmx/evmcs.h           |   4 +
 arch/x86/kvm/vmx/nested.c          |  41 +++-
 arch/x86/kvm/x86.c                 |  15 +-
 arch/x86/kvm/x86.h                 |   1 +
 14 files changed, 539 insertions(+), 46 deletions(-)
 create mode 100644 arch/x86/kvm/svm/hyperv.c
Signature · 1 line
2.35.1