Skip to content

Volatile fanotify marks

Amir Goldstein linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fsnotify: move inotify control flags to mark flagsfs/notify/fsnotify.c fs/notify/inotify/inotify_fsnotify.c fs/notify/inotify/inotify_user.c +1 more+34 -232 replies
2/5fsnotify: pass flags argument to fsnotify_add_mark()fs/notify/mark.c include/linux/fsnotify_backend.h kernel/audit_fsnotify.c+17 -170 replies
3/5fsnotify: allow adding an inode mark without pinning inodefs/notify/mark.c include/linux/fsnotify_backend.h+65 -83 replies
4/5fanotify: add support for exclusive create of markfs/notify/fanotify/fanotify_user.c include/linux/fanotify.h include/uapi/linux/fanotify.h+16 -611 replies
5/5fanotify: add support for "volatile" inode marksfs/notify/fanotify/fanotify_user.c include/linux/fanotify.h include/uapi/linux/fanotify.h+20 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Volatile fanotify marks

Jan,

Following RFC discussion [1], following are the volatile mark patches.

Tested both manually and with this LTP test [2].
I was struggling with this test for a while because drop caches did not get rid of the un-pinned inode when test was run with ext2 or ext4 on my test VM. With xfs, the test works fine for me, but it may not work for everyone.

Perhaps you have a suggestion for a better way to test inode eviction.

Thanks,
Amir.

[1] https://lore.kernel.org/linux-fsdevel/CAOQ4uxiRDpuS=2uA6+ZUM7yG9vVU-u212tkunBmSnP_u=mkv=Q@mail.gmail.com/
[2] https://github.com/amir73il/ltp/commits/fan_volatile

Amir Goldstein (5):
fsnotify: move inotify control flags to mark flags
fsnotify: pass flags argument to fsnotify_add_mark()
fsnotify: allow adding an inode mark without pinning inode
fanotify: add support for exclusive create of mark
fanotify: add support for "volatile" inode marks

 fs/notify/fanotify/fanotify_user.c   | 32 +++++++++--
 fs/notify/fsnotify.c                 |  4 +-
 fs/notify/inotify/inotify_fsnotify.c |  2 +-
 fs/notify/inotify/inotify_user.c     | 40 +++++++++-----
 fs/notify/mark.c                     | 83 +++++++++++++++++++++++-----
 include/linux/fanotify.h             |  9 ++-
 include/linux/fsnotify_backend.h     | 32 ++++++-----
 include/uapi/linux/fanotify.h        |  2 +
 kernel/audit_fsnotify.c              |  3 +-
 9 files changed, 151 insertions(+), 56 deletions(-)
Signature · 1 line
2.25.1