Skip to content

Clean ups and preparation for IPC abstraction in the SOF driver

Ranjani Sridharan alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 4 repliesIn review
  2. v118 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Use guid_t instead of u8 array for uuid and the helper guid_is_null()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18ASoC: SOF: remove snd_sof_pipeline_find()sound/soc/sof/sof-audio.c sound/soc/sof/sof-audio.h+0 -180 replies
2/18ASoC: SOF: simplify snd_sof_device_remove()sound/soc/sof/core.c+1 -90 replies
3/18ASoC: SOF: set swidget's core for scheduler widgetsound/soc/sof/sof-audio.c sound/soc/sof/topology.c+6 -180 replies
4/18ASoC: SOF: sof-audio: removed unused functionsound/soc/sof/sof-audio.c sound/soc/sof/sof-audio.h+0 -160 replies
5/18ASoC: SOF: topology: remove redundant codesound/soc/sof/topology.c+0 -80 replies
6/18ASoC: SOF: topology: remove redundant code in sof_link_afe_load()sound/soc/sof/topology.c+0 -70 replies
7/18ASoC: SOF: topology: Drop the size parameter from struct sof_topology_tokensound/soc/sof/topology.c+75 -880 replies
8/18ASoC: SOF: topology: Modify the get_token op for string tokenssound/soc/sof/topology.c+4 -80 replies
9/18ASoC: SOF: topology: expose some get_token opssound/soc/sof/sof-audio.h sound/soc/sof/topology.c+10 -50 replies
10/18ASoC: SOF: change comp_dai to a pointer in struct snd_sof_daisound/soc/sof/pcm.c sound/soc/sof/sof-audio.c sound/soc/sof/sof-audio.h +1 more+12 -310 replies
11/18ASoC: SOF: make struct snd_sof_widget IPC agnosticinclude/sound/sof/topology.h sound/soc/sof/sof-audio.h sound/soc/sof/topology.c+11 -210 replies
12/18ASoC: SOF: topology: make sof_route_load() IPC agnosticsound/soc/sof/sof-audio.c sound/soc/sof/topology.c+6 -260 replies
13/18ASoC: SOF: Add a tuples array to struct snd_sof_widgetsound/soc/sof/sof-audio.h+15 -00 replies
14/18ASoC: SOF: topology: Modify signature for token parsing functionssound/soc/sof/topology.c+52 -260 replies
15/18ASoC: SOF: topology: Rename arguments in sof_parse_token_sets()sound/soc/sof/topology.c+10 -110 replies
16/18ASoC: SOF: topology: Rename arguments in sof_parse_tokens()sound/soc/sof/topology.c+18 -70 replies
17/18ASoC: SOF: make struct snd_sof_dai IPC agnosticinclude/sound/sof/dai.h sound/soc/sof/intel/hda-dai.c sound/soc/sof/intel/hda.c +4 more+143 -760 replies
18/18ASoC: SOF: move definition of snd_sof_ipc to header filesound/soc/sof/ipc.c sound/soc/sof/sof-priv.h+12 -120 replies

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchBard LiaoPéter UjfalusiPierre-Louis Bossart
1/18R-b R-b
2/18R-b R-b
3/18R-b R-b
4/18R-b
5/18R-b R-b R-b
6/18R-b R-b R-b
7/18R-b R-b R-b
8/18R-b R-b R-b
9/18R-b R-b R-b
10/18R-b R-b R-b
11/18R-b R-b R-b
12/18R-b R-b R-b
13/18R-b R-b R-b
14/18R-b R-b R-b
15/18R-b R-b R-b
16/18R-b R-b R-b
17/18R-b R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/18] Clean ups and preparation for IPC abstraction in the SOF driver

In preparation for adding support for the new IPC version that has been introduced in the SOF firmware, this patch set includes some clean ups and necessary modifications to commonly used functions that will be re-used across different IPC-specific code.

Changes in v2:
- Use guid_t instead of u8 array for uuid and the helper guid_is_null()

Pierre-Louis Bossart (1):
ASoC: SOF: sof-audio: removed unused function

Rander Wang (1):
ASoC: SOF: move definition of snd_sof_ipc to header file

Ranjani Sridharan (16):
ASoC: SOF: remove snd_sof_pipeline_find()
ASoC: SOF: simplify snd_sof_device_remove()
ASoC: SOF: set swidget's core for scheduler widget
ASoC: SOF: topology: remove redundant code
ASoC: SOF: topology: remove redundant code in sof_link_afe_load()
ASoC: SOF: topology: Drop the size parameter from struct
sof_topology_token
ASoC: SOF: topology: Modify the get_token op for string tokens
ASoC: SOF: topology: expose some get_token ops
ASoC: SOF: change comp_dai to a pointer in struct snd_sof_dai
ASoC: SOF: make struct snd_sof_widget IPC agnostic
ASoC: SOF: topology: make sof_route_load() IPC agnostic
ASoC: SOF: Add a tuples array to struct snd_sof_widget
ASoC: SOF: topology: Modify signature for token parsing functions
ASoC: SOF: topology: Rename arguments in sof_parse_token_sets()
ASoC: SOF: topology: Rename arguments in sof_parse_tokens()
ASoC: SOF: make struct snd_sof_dai IPC agnostic

 include/sound/sof/dai.h       |   5 +
 include/sound/sof/topology.h  |   8 -
 sound/soc/sof/core.c          |  10 +-
 sound/soc/sof/intel/hda-dai.c |  27 ++-
 sound/soc/sof/intel/hda.c     |  39 +++-
 sound/soc/sof/ipc.c           |  12 --
 sound/soc/sof/pcm.c           |  77 +++----
 sound/soc/sof/sof-audio.c     | 108 +++-------
 sound/soc/sof/sof-audio.h     |  30 ++-
 sound/soc/sof/sof-priv.h      |  12 ++
 sound/soc/sof/topology.c      | 392 +++++++++++++++++-----------------
 11 files changed, 354 insertions(+), 366 deletions(-)
Signature · 1 line
2.25.1