Skip to content

add LOG_UNSUPP log type + mark hcalls as unsupp

Daniel Henrique Barboza qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9util/log.c: add LOG_UNSUPP typeinclude/qemu/log.h util/log.c+4 -10 replies
2/9hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupportedhw/ppc/spapr_hcall.c+1 -10 replies
3/9hw/ppc/spapr_hcall.c: log h_invalidate_pid() as unsupportedhw/ppc/spapr_hcall.c+1 -10 replies
4/9hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() as unsupportedhw/ppc/spapr_hcall.c+2 -00 replies
5/9hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS as unsupportedhw/ppc/spapr_hcall.c+17 -00 replies
6/9hw/ppc/spapr_hcall.c: log H_BEST_ENERGY as unsupportedhw/ppc/spapr_hcall.c include/hw/ppc/spapr.h+28 -00 replies
7/9hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES as unsupportedhw/ppc/spapr_hcall.c include/hw/ppc/spapr.h+19 -00 replies
8/9hw/ppc/spapr_hcall.c: log H_GET_PPP as unsupportedhw/ppc/spapr_hcall.c+16 -00 replies
9/9hw/ppc/spapr_hcall.c: log H_VIOCTL as unsupportedhw/ppc/spapr_hcall.c include/hw/ppc/spapr.h+15 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp

Hi,

I got a lot of noise trying to debug an AIX guest in a pseries machine when running with '-d unimp'. The reason is that there is no distinction between features (in my case, hypercalls) that are unimplemented because we never considered, versus features that we made a design choice not to implement.

This series adds a new log type, LOG_UNSUPP, as a way to filter the second case. After changing the log level of existing unsupported pseries hypercalls, -d unimp was reporting just the ones that I need to worry about and decide whether we should implement it or mark as unsupported in our model. After this series there's still one hypercall thgat is being thrown by AIX. We'll deal with that another day.

I am posting this a little too close of the soft freeze. If we manage to get it reviewed in time, since it's a debug QoL change that doesn't break anything, I'd say we take it.

Also, I didn't find the maintainer for the util/log.c file. Let me know if I need to CC someone in special for this file.

Daniel Henrique Barboza (9):
util/log.c: add LOG_UNSUPP type
hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported hw/ppc/spapr_hcall.c: log h_invalidate_pid() as unsupported hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() as unsupported hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS as unsupported hw/ppc/spapr_hcall.c: log H_BEST_ENERGY as unsupported hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES as unsupported hw/ppc/spapr_hcall.c: log H_GET_PPP as unsupported hw/ppc/spapr_hcall.c: log H_VIOCTL as unsupported

 hw/ppc/spapr_hcall.c   | 98 +++++++++++++++++++++++++++++++++++++++++-
 include/hw/ppc/spapr.h |  3 ++
 include/qemu/log.h     |  3 +-
 util/log.c             |  2 +
 4 files changed, 103 insertions(+), 3 deletions(-)
Signature · 1 line
2.35.1