Skip to content

RFC common kmalloc subsystem on SLAB/SLUB

Hyeonggon Yoo linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest15 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15mm/slab: cleanup slab_alloc() and slab_alloc_node()mm/slab.c+50 -662 replies
2/15mm/sl[auo]b: remove CONFIG_NUMA ifdefs for common functionsinclude/linux/slab.h mm/slab.c mm/slob.c +1 more+35 -1970 replies
3/15mm/sl[au]b: remove CONFIG_TRACING ifdefs for tracing functionsinclude/linux/slab.h mm/slab.c mm/slab_common.c +1 more+0 -390 replies
4/15mm/sl[auo]b: fold kmalloc_order() into kmalloc_large()include/linux/slab.h mm/slab_common.c+5 -201 reply
5/15mm/slub: move kmalloc_large_node() to slab_common.cinclude/linux/slab.h mm/slab_common.c mm/slub.c+33 -431 reply
6/15mm/slab_common: cleanup kmalloc_large()include/linux/slab.h mm/slab_common.c+5 -270 replies
7/15mm/sl[au]b: kmalloc_node: pass large requests to page allocatorinclude/linux/slab.h+18 -61 reply
8/15mm/sl[auo]b: cleanup kmalloc()include/linux/slab.h mm/slab.c mm/slub.c+31 -743 replies
9/15mm/slab: kmalloc: pass requests larger than order-1 page to page allocatorinclude/linux/slab.h mm/slab.c mm/slab.h +2 more+57 -582 replies
10/15mm/sl[auo]b: print cache name in tracepointsinclude/trace/events/kmem.h mm/slab.c mm/slab.h +3 more+38 -300 replies
11/15mm/sl[auo]b: use same tracepoint in kmalloc and normal cachesinclude/trace/events/kmem.h mm/slab.c mm/slab_common.c +2 more+27 -982 replies
12/15mm/sl[au]b: generalize kmalloc subsysteminclude/linux/slab.h mm/slab.c mm/slab_common.c +2 more+166 -2600 replies
13/15mm/sl[au]b: remove kmem_cache_alloc_node_trace()include/linux/slab.h+8 -70 replies
14/15mm/sl[auo]b: move definition of __ksize() to mm/slab.hinclude/linux/slab.h mm/slab.h mm/slab_common.c +1 more+3 -120 replies
15/15mm/sl[au]b: check if large object is valid in __ksize()mm/slab_common.c+5 -11 reply

Reviews trailers per patch

4 of 15 patches have a Reviewed-by or Acked-by.

PatchVlastimil Babka
1/15
2/15
3/15
4/15R-b
5/15
6/15
7/15R-b
8/15R-b
9/15
10/15
11/15
12/15
13/15
14/15R-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH v1 00/15] common kmalloc subsystem on SLAB/SLUB

Hello, this series is cleanup of slab common code.

After this series, kmalloc subsystem is perfectly generalized between SLAB and SLUB.

This series is not small, and some of review and discussion may be needed. But I bet you will like this! :D

Many thanks to Matthew, Marco, Vlastimil who gave comments in previous series.

Any feedbacks will be appreciated.
Thanks!

========= series description ==========

patch 1 makes slab_alloc_node() in SLAB available for non-NUMA configurations for further cleanup.

patch 2-8 are cleanup of unnecessary CONFIG_TRACING/NUMA ifdefs and duplicate code. (and small optimization of kmalloc_node())

patch 9 makes SLAB pass requests larger than order-1 page to page allocator. This is useful for further generalization.

patch 10-11 are cleanup of tracepoints. Currently there are five trace points in slab: kmalloc, kmalloc_node, kmem_cache_alloc, kmem_cahce_alloc_node, kmem_cache_free, kfree.

patch 10-11 make tracepoints print cache name and convert every tracepoint to kmem_cache_alloc_node and kmem_cache_free.

patch 12 generalizes whole kmalloc subsystem on SLAB and SLUB.

patch 13 removes kmem_cache_alloc_node() that became useless after patch 12.

patch 14-15 are small improvements of __ksize().

Hyeonggon Yoo (15):
mm/slab: cleanup slab_alloc() and slab_alloc_node() mm/sl[auo]b: remove CONFIG_NUMA ifdefs for common functions mm/sl[au]b: remove CONFIG_TRACING ifdefs for tracing functions mm/sl[auo]b: fold kmalloc_order() into kmalloc_large() mm/slub: move kmalloc_large_node() to slab_common.c mm/slab_common: cleanup kmalloc_large()
mm/sl[au]b: kmalloc_node: pass large requests to page allocator mm/sl[auo]b: cleanup kmalloc()
mm/slab: kmalloc: pass requests larger than order-1 page to page
allocator
mm/sl[auo]b: print cache name in tracepoints mm/sl[auo]b: use same tracepoint in kmalloc and normal caches mm/sl[au]b: generalize kmalloc subsystem
mm/sl[au]b: remove kmem_cache_alloc_node_trace() mm/sl[auo]b: move definition of __ksize() to mm/slab.h mm/sl[au]b: check if large object is valid in __ksize()

 include/linux/slab.h        | 252 +++++++++++---------------
 include/trace/events/kmem.h | 107 ++---------
 mm/slab.c                   | 347 ++++++++----------------------------
 mm/slab.h                   |   9 +
 mm/slab_common.c            | 128 ++++++++++---
 mm/slob.c                   |  69 +++----
 mm/slub.c                   | 237 ++----------------------
 7 files changed, 346 insertions(+), 803 deletions(-)
Signature · 1 line
2.33.1