Skip to content

powerpc/rtas: various cleanups and improvements

Nicholas Piggin linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14powerpc/rtas: Move rtas entry assembly into its own filearch/powerpc/kernel/Makefile arch/powerpc/kernel/entry_32.S arch/powerpc/kernel/entry_64.S +1 more+200 -2000 replies
2/14powerpc/rtas: Make enter_rtas a nokprobe symbol on 64-bitarch/powerpc/kernel/rtas_entry.S+1 -00 replies
3/14powerpc/rtas: Fix whitespace in rtas_entry.Sarch/powerpc/kernel/rtas_entry.S+17 -170 replies
4/14powerpc/rtas: Call enter_rtas with MSR[EE] disabledarch/powerpc/kernel/rtas.c arch/powerpc/kernel/rtas_entry.S+5 -161 reply
5/14powerpc/rtas: Modernise RI clearing on 64-bitarch/powerpc/kernel/rtas_entry.S+3 -31 reply
6/14powerpc/rtas: Load rtas entry MSR explicitlyarch/powerpc/kernel/rtas_entry.S+1 -81 reply
7/14powerpc/rtas: PACA can be restored directly from SPRGarch/powerpc/kernel/rtas_entry.S+4 -91 reply
8/14powerpc/rtas: call enter_rtas in real-mode on 64-bitarch/powerpc/kernel/rtas.c arch/powerpc/kernel/rtas_entry.S+17 -302 replies
9/14powerpc/rtas: Leave MSR[RI] enabled over RTAS callarch/powerpc/kernel/rtas.c arch/powerpc/kernel/rtas_entry.S+4 -101 reply
10/14powerpc/rtas: replace rtas_call_unlocked with raw_rtas_callarch/powerpc/include/asm/rtas.h arch/powerpc/kernel/rtas.c arch/powerpc/platforms/pseries/hotplug-cpu.c +2 more+33 -351 reply
11/14powerpc/rtas: tidy __fetch_rtas_last_errorarch/powerpc/kernel/rtas.c+9 -210 replies
12/14powerpc/rtas: Close theoretical memory leakarch/powerpc/kernel/rtas.c+4 -31 reply
13/14powerpc/rtas: enture rtas_call is called with MMU enabledarch/powerpc/kernel/rtas.c+5 -01 reply
14/14powerpc/rtas: Consolidate and improve checking for rtas callersarch/powerpc/kernel/rtas.c+17 -61 reply

Reviews trailers per patch

6 of 14 patches have a Reviewed-by or Acked-by.

PatchLaurent Dufour
1/14
2/14
3/14
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14
9/14
10/14R-b
11/14
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] powerpc/rtas: various cleanups and improvements

I had a bunch of random little fixes and cleanups around and was prompted to put them together and make a change to call RTAS with MSR[RI] enabled because of a report of the hard lockup watchdog NMI IPI hitting in an rtas call which then crashed because it's unrecoverable.

Could possibly move patch 9 earlier if it would help with backporting.

Thanks,
Nick

Nicholas Piggin (14):
powerpc/rtas: Move rtas entry assembly into its own file powerpc/rtas: Make enter_rtas a nokprobe symbol on 64-bit powerpc/rtas: Fix whitespace in rtas_entry.S powerpc/rtas: Call enter_rtas with MSR[EE] disabled powerpc/rtas: Modernise RI clearing on 64-bit powerpc/rtas: Load rtas entry MSR explicitly powerpc/rtas: PACA can be restored directly from SPRG powerpc/rtas: call enter_rtas in real-mode on 64-bit powerpc/rtas: Leave MSR[RI] enabled over RTAS call powerpc/rtas: replace rtas_call_unlocked with raw_rtas_call powerpc/rtas: tidy __fetch_rtas_last_error powerpc/rtas: Close theoretical memory leak powerpc/rtas: enture rtas_call is called with MMU enabled powerpc/rtas: Consolidate and improve checking for rtas callers

 arch/powerpc/include/asm/rtas.h              |   4 +-
 arch/powerpc/kernel/Makefile                 |   2 +-
 arch/powerpc/kernel/entry_32.S               |  49 ------
 arch/powerpc/kernel/entry_64.S               | 150 -------------------
 arch/powerpc/kernel/rtas.c                   | 132 +++++++++-------
 arch/powerpc/kernel/rtas_entry.S             | 144 ++++++++++++++++++
 arch/powerpc/platforms/pseries/hotplug-cpu.c |   2 +-
 arch/powerpc/platforms/pseries/ras.c         |   7 +-
 arch/powerpc/xmon/xmon.c                     |   2 +-
 9 files changed, 227 insertions(+), 265 deletions(-)
 create mode 100644 arch/powerpc/kernel/rtas_entry.S
Signature · 1 line
2.23.0