Writeback fixes and improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 1 replyIn review
- v28 patches 8 repliesSuperseded
- v18 patches 0 repliesSuperseded
Changes in v3 from the cover letter
- Rebased on master
- Dropped the frame dumping patches
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tests/kms_writeback: Use endianness accessor to fill pixelslib/ tests/ | +10 | 1 reply | |
| 2/3 | lib/igt_fb: Ignore the X component when computing CRClib/ | +16 | 0 replies | |
| 3/3 | tests/kms_writeback: Use a garbage X value to create fill our test buffertests/ | +1 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Pekka Paalanen |
|---|---|
| 1/3 | A-b |
| 2/3 | A-b |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t v3 0/3] Writeback fixes and improvements
Hi,
Here's a series addressing the writeback-check-output test not passing on vc4. This is due to the fact that the writeback controller will force the X component to 0, while we expect the output and input buffers to be identical, and the input buffer has 0xff.
This series tackles this by adding some support to dump the faulty frames in PNG and raw, which proved to be useful while debugging this series. Then, we rework the hash function to ignore the X component of our buffer and only hash the pixels themselves.
Finally, we change the input buffer X value to a garbage, different from 0 and 0xff, value to make sure the hardware properly ignores the component and doesn't treat it as alpha.
Let me know what you think,
Maxime
Changes from v2:
- Rebased on master
- Dropped the frame dumping patches
Changes from v1:
- Rebased on master
- Added maintainers to the recipients
Maxime Ripard (3):
tests/kms_writeback: Use endianness accessor to fill pixels lib/igt_fb: Ignore the X component when computing CRC tests/kms_writeback: Use a garbage X value to create fill our test
buffer
lib/igt_core.h | 9 +++++++++ lib/igt_fb.c | 20 ++++++++++++++++---- tests/kms_writeback.c | 4 ++-- 3 files changed, 27 insertions(+), 6 deletions(-)
Signature · 1 line
2.36.1