Skip to content

netfilter: conntrack: ignore overly delayed tcp packets

Florian Westphal netfilter-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4netfilter: conntrack: remove pr_debug callsites from tcp trackernet/netfilter/nf_conntrack_proto_tcp.c+4 -480 replies
2/4netfilter: conntrack: prepare tcp_in_window for tristate return valuenet/netfilter/nf_conntrack_proto_tcp.c+56 -180 replies
3/4netfilter: conntrack: ignore overly delayed tcp packetsnet/netfilter/nf_conntrack_proto_tcp.c+21 -240 replies
4/4netfilter: conntrack: remove unneeded indent levelnet/netfilter/nf_conntrack_proto_tcp.c+45 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nf-next 0/4] netfilter: conntrack: ignore overly delayed tcp packets

If 'nf_conntrack_tcp_loose' is off (the default), tcp packets that are outside of the current window are marked as INVALID.

nf/iptables rulesets often drop such packets via 'ct state invalid' or similar checks.

For overly delayed acks, this can be a nuisance if such 'invalid' packets are also logged.

Since they are not invalid in a strict sense, just ignore them, i.e. conntrack won't extend timeout or change state so that they do not match invalid state rules anymore.

This also avoids unwantend connection stalls in case conntrack considers retransmission (of data that did not reach the peer) as too old.

Florian Westphal (4):
netfilter: conntrack: remove pr_debug callsites from tcp tracker
netfilter: conntrack: prepare tcp_in_window for tristate return value
netfilter: conntrack: ignore overly delayed tcp packets
netfilter: conntrack: remove unneeded indent level

 net/netfilter/nf_conntrack_proto_tcp.c | 257 ++++++++++++-------------
 1 file changed, 119 insertions(+), 138 deletions(-)
Signature · 1 line
2.34.1