Skip to content

RFC nvmet: export discovery subsystem

Hannes Reinecke linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvmet: expose discovery subsystem in sysfsdrivers/nvme/target/configfs.c drivers/nvme/target/core.c drivers/nvme/target/discovery.c+13 -617 replies
2/3nvmet: restrict setting of discovery_nqn to discovery subsystemdrivers/nvme/target/configfs.c+27 -55 replies
3/3nvmet: do not allow to create a subsystem with the discovery NQNdrivers/nvme/target/configfs.c+3 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] nvmet: export discovery subsystem

Hi all,

here's a patchset to expose the discovery subsystem in configfs. The current implementation is has a rather 'odd' discovery subsystem implementation; there is one discovery subsystem structure, but the details of this subsystem will be modified depending from which port (and, consequently, port->subsystem link) is has been called. This makes is really awkward to assign unique properties to it (like the unique discovery NQN).

With this patchset the discovery subsystem is elevated to a 'real' subsystem, with a normal subsystem entry in sysfs and with activation of it by linking this subsystem to ports.
This gives full control to the user which subsystem should be visible on this discovery controller, and also allows to have a discovery controller with no I/O subsystems at all.

Drawback is that it's a change in operation, as the user _has_ to link the subsystem to individual ports.

As usual, comments and reviews are welcome.

Hannes Reinecke (3):
nvmet: expose discovery subsystem in sysfs
nvmet: restrict setting of discovery_nqn to discovery subsystem
nvmet: do not allow to create a subsystem with the discovery NQN

 drivers/nvme/target/configfs.c  | 46 +++++++++++++++++++++++++++++----
 drivers/nvme/target/core.c      |  1 +
 drivers/nvme/target/discovery.c |  7 +----
 3 files changed, 43 insertions(+), 11 deletions(-)
Signature · 1 line
2.29.2