Skip to content

block/vmdk: Fix reopening bs->file

Hanna Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block/vmdk: Fix reopening bs->fileblock/vmdk.c+55 -10 replies
2/2iotests/reopen-file: Test reopening file childtests/qemu-iotests/tests/reopen-file tests/qemu-iotests/tests/reopen-file.out+93 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for-7.0 0/2] block/vmdk: Fix reopening bs->file

Hi,

A couple of months ago I noticed that changing a vmdk node’s file child through blockdev-reopen would crash qemu. I started writing a fix at some point, got distracted, but now here it is.

Hanna Reitz (2):
block/vmdk: Fix reopening bs->file
iotests/reopen-file: Test reopening file child

 block/vmdk.c                             | 56 ++++++++++++++-
 tests/qemu-iotests/tests/reopen-file     | 88 ++++++++++++++++++++++++
 tests/qemu-iotests/tests/reopen-file.out |  5 ++
 3 files changed, 148 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/tests/reopen-file
 create mode 100644 tests/qemu-iotests/tests/reopen-file.out
Signature · 1 line
2.35.1