Skip to content

x86: Avoid CONFIG_X86_X32_ABI=y with llvm-objcopy

Nathan Chancellor alsa-devel linux-fsdevel linux-xfs lkml llvm 1 version Applied

Status from this message: The following commit has been merged into the x86/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86: Remove toolchain check for X32 ABI capabilityarch/x86/Kconfig arch/x86/Makefile arch/x86/entry/syscalls/Makefile +7 more+28 -480 replies
2/2x86/Kconfig: Do not allow CONFIG_X86_X32_ABI=y with llvm-objcopyarch/x86/Kconfig+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] x86: Avoid CONFIG_X86_X32_ABI=y with llvm-objcopy

This series disables CONFIG_X86_X32_ABI=y with llvm-objcopy, which has had two outstanding issues, which are further outlined in the second patch:

https://github.com/ClangBuiltLinux/linux/issues/514
https://github.com/ClangBuiltLinux/linux/issues/1141

The first patch is from Masahiro, which moves the CONFIG_X86_X32_ABI back into Kconfig proper. It was initially pushed as an RFC:

https://lore.kernel.org/r/[email protected]/

The conclusion of that thread was that the check was still needed because of the two issues above. However, with the introduction of IBT, specifically commit 41c5ef31ad71 ("x86/ibt: Base IBT bits"), the second issue linked above becomes visible with allmodconfig, which heavily impacts automated testing.

The second patch builds on the first by just universally disabling CONFIG_X86_X32_ABI when using llvm-objcopy at configuration time so that neither issue is visible.

While it is unlikely that these issues will be fixed in LLVM, this could eventually become a version check.

This is based on -tip x86/core and I would like for both patches to go with the IBT changes so that there is no build breakage.

Masahiro Yamada (1):
x86: Remove toolchain check for X32 ABI capability

Nathan Chancellor (1):
x86/Kconfig: Do not allow CONFIG_X86_X32_ABI=y with llvm-objcopy

 arch/x86/Kconfig                       | 13 +++++++------
 arch/x86/Makefile                      | 16 ----------------
 arch/x86/entry/syscalls/Makefile       |  2 +-
 arch/x86/include/asm/syscall_wrapper.h |  6 +++---
 arch/x86/include/asm/vdso.h            |  2 +-
 arch/x86/kernel/process_64.c           |  2 +-
 fs/fuse/ioctl.c                        |  2 +-
 fs/xfs/xfs_ioctl32.c                   |  2 +-
 sound/core/control_compat.c            | 16 ++++++++--------
 sound/core/pcm_compat.c                | 20 ++++++++++----------
 10 files changed, 33 insertions(+), 48 deletions(-)

base-commit: f8afc9d88e65d189653f363eacc1f3131216ef7c

Signature · 1 line
2.35.1