Skip to content

Fixes for static builds

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5libxtables: Fix for warning in xtables_ipmask_to_numericlibxtables/xtables.c+1 -10 replies
2/5Simplify static build extension loadinginclude/xtables.h iptables/ip6tables-standalone.c iptables/iptables-restore.c +9 more+9 -290 replies
3/5xtables: Call init_extensions{,a,b}() for static buildsiptables/xtables-arp.c iptables/xtables-eb.c iptables/xtables-monitor.c +4 more+26 -32 replies
4/5nft: Review static extension loadingiptables/xtables-restore.c iptables/xtables-save.c iptables/xtables-standalone.c +1 more+13 -160 replies
5/5tests: shell: Fix 0004-return-codes_0 for static buildsiptables/tests/shell/testcases/iptables/0004-return-codes_0+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [iptables PATCH 0/5] Fixes for static builds

This series formally submits a slightly modified version of the patch attached to nfbz#1593 in patch 3. In addition to that:

Patch 1 is pure collateral and unrelated to the remaining series.

Patch 2 simplifies the compile-time conditional init-calls a bit. Done before the actual fix to avoid adding #ifdefs only to remove them again in the same series.

Patch 3 Fixes static builds of arp- and ebtables-nft, kindly provided by Ettiene and slightly adjusted by me.

Patch 4 holds a mini-review of the resulting init_extensions*() call sites.

Patch 5 fixes shell testsuite for use with static builds.

Etienne (1):
xtables: Call init_extensions{,a,b}() for static builds

Phil Sutter (4):
libxtables: Fix for warning in xtables_ipmask_to_numeric Simplify static build extension loading
nft: Review static extension loading
tests: shell: Fix 0004-return-codes_0 for static builds

 include/xtables.h                                  |  9 +++++++++
 iptables/ip6tables-standalone.c                    |  3 ---
 iptables/iptables-restore.c                        |  4 ----
 iptables/iptables-save.c                           |  4 ----
 iptables/iptables-standalone.c                     |  2 --
 .../shell/testcases/iptables/0004-return-codes_0   |  2 +-
 iptables/xtables-arp.c                             |  4 +---
 iptables/xtables-eb.c                              |  4 +---
 iptables/xtables-monitor.c                         |  4 ++--
 iptables/xtables-restore.c                         | 10 ++++++----
 iptables/xtables-save.c                            | 10 ++++++----
 iptables/xtables-standalone.c                      | 10 ++++++----
 iptables/xtables-translate.c                       | 14 ++++++++------
 libxtables/xtables.c                               |  2 +-
 14 files changed, 41 insertions(+), 41 deletions(-)
Signature · 1 line
2.34.1