Skip to content

Crossing our fingers is not a strategy

[email protected] linux-nfs 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/29 patches 0 repliesNew
  2. v2 posting 1/29 patches 3 repliesSuperseded
  3. v11 patch 5 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9NFS: Fix memory allocation in rpc_malloc()include/linux/sunrpc/sched.h net/sunrpc/sched.c+15 -70 replies
2/9NFS: Fix memory allocation in rpc_alloc_task()net/sunrpc/sched.c+7 -30 replies
3/9SUNRPC: Fix unx_lookup_cred() allocationnet/sunrpc/auth_unix.c+10 -80 replies
4/9SUNRPC: Make the rpciod and xprtiod slab allocation modes consistentnet/sunrpc/backchannel_rqst.c net/sunrpc/rpcb_clnt.c net/sunrpc/socklib.c +2 more+15 -160 replies
5/9NFS: nfsiod should not block forever in mempool_alloc()fs/nfs/internal.h fs/nfs/pnfs_nfs.c fs/nfs/write.c +1 more+23 -180 replies
6/9NFS: Avoid writeback threads getting stuck in mempool_alloc()fs/nfs/pagelist.c fs/nfs/write.c+13 -70 replies
7/9NFSv4/pnfs: Ensure pNFS allocation modes are consistent with nfsiodfs/nfs/nfs42proc.c fs/nfs/pnfs.c+18 -230 replies
8/9pNFS/flexfiles: Ensure pNFS allocation modes are consistent with nfsiodfs/nfs/flexfilelayout/flexfilelayout.c+21 -290 replies
9/9pNFS/files: Ensure pNFS allocation modes are consistent with nfsiodfs/nfs/filelayout/filelayout.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] Crossing our fingers is not a strategy

From: Trond Myklebust <[email protected]>

We'd like to avoid GFP_NOWAIT whenever possible, because it has no fall- back reclaim strategy for dealing with a failure of the initial allocation.
At the same time, memory pools appear to be suboptimal as an allocation strategy when used with anything other than GFP_NOWAIT, since they cause threads to hang upon failure.

This patch series therefore aims to demote the mempools to being a strategy of last resort, with the primary allocation strategy being to use the underlying slabs.
While we're at it, we want to ensure that rpciod, xprtiod and nfsiod all use the same allocation strategy, so that the latter two don't thwart our ability to complete writeback RPC calls by getting blocked in the mm layer.

Trond Myklebust (9):
NFS: Fix memory allocation in rpc_malloc()
NFS: Fix memory allocation in rpc_alloc_task()
SUNRPC: Fix unx_lookup_cred() allocation
SUNRPC: Make the rpciod and xprtiod slab allocation modes consistent
NFS: nfsiod should not block forever in mempool_alloc()
NFS: Avoid writeback threads getting stuck in mempool_alloc() NFSv4/pnfs: Ensure pNFS allocation modes are consistent with nfsiod pNFS/flexfiles: Ensure pNFS allocation modes are consistent with
nfsiod
pNFS/files: Ensure pNFS allocation modes are consistent with nfsiod

 fs/nfs/filelayout/filelayout.c         |  2 +-
 fs/nfs/flexfilelayout/flexfilelayout.c | 50 +++++++++++---------------
 fs/nfs/internal.h                      |  7 ++++
 fs/nfs/nfs42proc.c                     |  2 +-
 fs/nfs/pagelist.c                      | 10 +++---
 fs/nfs/pnfs.c                          | 39 +++++++++-----------
 fs/nfs/pnfs_nfs.c                      |  8 +++--
 fs/nfs/write.c                         | 34 +++++++++---------
 include/linux/nfs_fs.h                 |  2 +-
 include/linux/sunrpc/sched.h           |  1 +
 net/sunrpc/auth_unix.c                 | 18 +++++-----
 net/sunrpc/backchannel_rqst.c          |  8 ++---
 net/sunrpc/rpcb_clnt.c                 |  4 +--
 net/sunrpc/sched.c                     | 31 ++++++++++------
 net/sunrpc/socklib.c                   |  3 +-
 net/sunrpc/xprt.c                      |  5 +--
 net/sunrpc/xprtsock.c                  | 11 +++---
 17 files changed, 123 insertions(+), 112 deletions(-)
Signature · 1 line
2.35.1