Skip to content

New CMCI storm mitigation for Intel CPUs

Tony Luck linux-edac linux-patches lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 6 repliesIn review

Changes in v2 from the cover letter

- Spelling fixes in commit message
- Many more comments explaining what is going on
- Change name of function that does tracking
- Change names for #defines for storm BEGIN/END
- #define for high threshold in decimal, not hex

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86/mce: Remove old CMCI storm mitigation codearch/x86/kernel/cpu/mce/core.c arch/x86/kernel/cpu/mce/intel.c arch/x86/kernel/cpu/mce/internal.h+1 -1701 reply
1/2x86/mce: Remove old CMCI storm mitigation codearch/x86/kernel/cpu/mce/core.c arch/x86/kernel/cpu/mce/intel.c arch/x86/kernel/cpu/mce/internal.h+1 -1700 replies
2/2x86/mce: Add per-bank CMCI storm mitigationarch/x86/kernel/cpu/mce/core.c arch/x86/kernel/cpu/mce/intel.c arch/x86/kernel/cpu/mce/internal.h+143 -113 replies
2/2x86/mce: Add per-bank CMCI storm mitigationarch/x86/kernel/cpu/mce/core.c arch/x86/kernel/cpu/mce/intel.c arch/x86/kernel/cpu/mce/internal.h+165 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] New CMCI storm mitigation for Intel CPUs

Two-part motivation:

1) Disabling CMCI globally is an overly big hammer

2) Intel signals some UNCORRECTED errors using CMCI (yes, turns out that was a poorly chosen name given the later evolution of the architecture). Since we don't want to miss those, the proposed storm code just bumps the threshold to (almost) maximum to mitigate, but not eliminate the storm. Note that the threshold only applies to corrected errors.

Patch 1 deletes the parts of the old storm code that are no longer needed.

Patch 2 adds the new per-bank mitigation.

Smita: Unless Boris finds a some more stuff for me to fix, this version will be a better starting point to merge with your changes.

Changes since v1 (based on feedback from Boris)

- Spelling fixes in commit message
- Many more comments explaining what is going on
- Change name of function that does tracking
- Change names for #defines for storm BEGIN/END
- #define for high threshold in decimal, not hex

Tony Luck (2):
x86/mce: Remove old CMCI storm mitigation code
x86/mce: Add per-bank CMCI storm mitigation

 arch/x86/kernel/cpu/mce/core.c     |  46 +++---
 arch/x86/kernel/cpu/mce/intel.c    | 241 ++++++++++++++---------------
 arch/x86/kernel/cpu/mce/internal.h |  10 +-
 3 files changed, 141 insertions(+), 156 deletions(-)

base-commit: ffb217a13a2eaf6d5bd974fc83036a53ca69f1e2

Signature · 1 line
2.35.1