Skip to content

u-boot-net refactors, fixes, cleanups

Marek Behún u-boot 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 3 repliesIn review
  2. v314 patches 10 repliesSuperseded
  3. v214 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v114 patches19 repliesSuperseded

Changes in v4 from the cover letter

- rebased on top of origin/next
- fixed binman failure: added #address-cells/#sice-cells to sandbox' test.dts' mdio node in patch

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14net: mdio-uclass: fix type for phy_mode_str and phy_handle_strnet/mdio-uclass.c+6 -50 replies
2/14net: mdio-uclass: use ARRAY_SIZE()net/mdio-uclass.c+5 -60 replies
3/14net: introduce helpers to get PHY ofnode from MACarch/sandbox/dts/test.dts drivers/core/ofnode.c drivers/core/read.c +4 more+96 -182 replies
4/14net: mdio-uclass: add wrappers for read/write/reset operationsinclude/miiphy.h net/mdio-uclass.c+62 -00 replies
5/14treewide: use dm_mdio_read/write/reset() wrappersdrivers/net/mdio_mux_sandbox.c net/mdio-mux-uclass.c net/mdio-uclass.c +2 more+27 -480 replies
6/14net: phy: fix parsing wrong propertydrivers/net/phy/phy.c+1 -10 replies
7/14net: introduce helpers to get PHY interface mode from a device/ofnodearch/sandbox/dts/test.dts board/st/stm32f746-disco/stm32f746-disco.c drivers/core/ofnode.c +38 more+166 -3720 replies
8/14treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAXdrivers/core/ofnode.c drivers/net/phy/aquantia.c include/phy_interface.h+3 -30 replies
9/14treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NAboard/freescale/corenet_ds/eth_hydra.c board/freescale/corenet_ds/eth_superhydra.c board/freescale/t104xrdb/eth.c +58 more+105 -1050 replies
10/14phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definitioninclude/phy_interface.h+2 -30 replies
11/14net: phy: xilinx: Check interface type in ->config(), not ->probe()drivers/net/phy/xilinx_gmii2rgmii.c+5 -50 replies
12/14net: phy: use ->is_c45 instead of is_10g_interface()drivers/net/phy/phy.c include/phy.h+4 -160 replies
13/14bcmgenet, sun8i_emac: Don't connect PHY two timesdrivers/net/bcmgenet.c drivers/net/sun8i_emac.c+0 -40 replies
14/14net: phy: don't require PHY interface mode during PHY creationboard/CZ.NIC/turris_mox/turris_mox.c board/boundary/nitrogen6x/nitrogen6x.c board/gdsys/a38x/controlcenterdc.c +14 more+75 -940 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchRamon FriedVladimir OlteanSimon GlassStefan RoesePatrice Chotard
1/14R-b R-b
2/14R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b R-b
7/14R-b T-b
8/14R-b R-b
9/14R-b R-b R-b
10/14R-b R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups

From: Marek Behún <[email protected]>

Hello,

this is v4 of https://patchwork.ozlabs.org/project/uboot/list/?series=290889.

Changes since v3:
- rebased on top of origin/next
- fixed binman failure: added #address-cells/#sice-cells to sandbox' test.dts' mdio node in patch

Changes since v2:
- added UT tests for ofnode_get_phy_node() and ofnode_get_phy_mode(), as requested by Simon

Marek Behún (14):
net: mdio-uclass: fix type for phy_mode_str and phy_handle_str
net: mdio-uclass: use ARRAY_SIZE()
net: introduce helpers to get PHY ofnode from MAC
net: mdio-uclass: add wrappers for read/write/reset operations
treewide: use dm_mdio_read/write/reset() wrappers
net: phy: fix parsing wrong property
net: introduce helpers to get PHY interface mode from a device/ofnode
treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX
treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA
phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum
definition
net: phy: xilinx: Check interface type in ->config(), not ->probe()
net: phy: use ->is_c45 instead of is_10g_interface() bcmgenet, sun8i_emac: Don't connect PHY two times
net: phy: don't require PHY interface mode during PHY creation

 arch/sandbox/dts/test.dts                   |  14 +++
 board/CZ.NIC/turris_mox/turris_mox.c        |   2 +-
 board/boundary/nitrogen6x/nitrogen6x.c      |   2 +-
 board/freescale/corenet_ds/eth_hydra.c      |   2 +-
 board/freescale/corenet_ds/eth_superhydra.c |   4 +-
 board/freescale/t104xrdb/eth.c              |   4 +-
 board/gdsys/a38x/controlcenterdc.c          |   7 +-
 board/gdsys/a38x/ihs_phys.c                 |   6 +-
 board/st/stm32f746-disco/stm32f746-disco.c  |  13 +--
 drivers/core/ofnode.c                       |  44 ++++++++
 drivers/core/read.c                         |  10 ++
 drivers/net/ag7xxx.c                        |   9 +-
 drivers/net/altera_tse.c                    |  17 +--
 drivers/net/bcm6348-eth.c                   |   8 +-
 drivers/net/bcmgenet.c                      |  12 +-
 drivers/net/designware.c                    |  10 +-
 drivers/net/dwc_eth_qos.c                   |  40 +------
 drivers/net/ethoc.c                         |   4 +-
 drivers/net/fec_mxc.c                       |  11 +-
 drivers/net/fm/b4860.c                      |   8 +-
 drivers/net/fm/eth.c                        |  13 +--
 drivers/net/fm/init.c                       |   8 +-
 drivers/net/fm/ls1043.c                     |   6 +-
 drivers/net/fm/ls1046.c                     |   8 +-
 drivers/net/fm/p1023.c                      |   4 +-
 drivers/net/fm/p4080.c                      |   6 +-
 drivers/net/fm/p5020.c                      |   6 +-
 drivers/net/fm/p5040.c                      |   6 +-
 drivers/net/fm/t1024.c                      |   4 +-
 drivers/net/fm/t1040.c                      |   4 +-
 drivers/net/fm/t2080.c                      |   6 +-
 drivers/net/fm/t4240.c                      |   6 +-
 drivers/net/fsl_enetc.c                     |  13 +--
 drivers/net/ftgmac100.c                     |  11 +-
 drivers/net/higmacv300.c                    |   9 +-
 drivers/net/ldpaa_eth/ldpaa_eth.c           |  28 +----
 drivers/net/ldpaa_eth/ldpaa_wriop.c         |  10 +-
 drivers/net/ldpaa_eth/ls1088a.c             |   4 +-
 drivers/net/ldpaa_eth/ls2080a.c             |   4 +-
 drivers/net/ldpaa_eth/lx2160a.c             |   4 +-
 drivers/net/macb.c                          |  10 +-
 drivers/net/mdio_mux_sandbox.c              |   6 +-
 drivers/net/mscc_eswitch/jr2_switch.c       |   2 +-
 drivers/net/mscc_eswitch/luton_switch.c     |   2 +-
 drivers/net/mscc_eswitch/ocelot_switch.c    |   2 +-
 drivers/net/mscc_eswitch/serval_switch.c    |   2 +-
 drivers/net/mscc_eswitch/servalt_switch.c   |   2 +-
 drivers/net/mt7620-eth.c                    |  45 +++-----
 drivers/net/mtk_eth.c                       |   8 +-
 drivers/net/mvgbe.c                         |   7 +-
 drivers/net/mvneta.c                        |  11 +-
 drivers/net/mvpp2.c                         |   9 +-
 drivers/net/pch_gbe.c                       |   4 +-
 drivers/net/phy/aquantia.c                  |   2 +-
 drivers/net/phy/ethernet_id.c               |   5 +-
 drivers/net/phy/phy.c                       | 117 +++++++-------------
 drivers/net/phy/xilinx_gmii2rgmii.c         |  14 +--
 drivers/net/pic32_eth.c                     |  11 +-
 drivers/net/qe/dm_qe_uec.c                  |  11 +-
 drivers/net/ravb.c                          |  19 +---
 drivers/net/sh_eth.c                        |  19 +---
 drivers/net/sni_ave.c                       |  16 +--
 drivers/net/sni_netsec.c                    |  10 +-
 drivers/net/sun8i_emac.c                    |  13 +--
 drivers/net/sunxi_emac.c                    |   5 +-
 drivers/net/ti/am65-cpsw-nuss.c             |  15 +--
 drivers/net/ti/cpsw.c                       |  10 +-
 drivers/net/ti/keystone_net.c               |  24 ++--
 drivers/net/tsec.c                          |   9 +-
 drivers/net/xilinx_axi_emac.c               |  10 +-
 drivers/net/zynq_gem.c                      |   9 +-
 include/_exports.h                          |   3 +-
 include/dm/ofnode.h                         |  27 +++++
 include/dm/read.h                           |  36 ++++++
 include/exports.h                           |   3 +-
 include/fm_eth.h                            |   2 +-
 include/miiphy.h                            |  31 ++++++
 include/phy.h                               |  40 ++-----
 include/phy_interface.h                     |  11 +-
 include/vsc9953.h                           |   2 +-
 net/mdio-mux-uclass.c                       |  16 +--
 net/mdio-uclass.c                           |  96 ++++++++--------
 test/dm/mdio.c                              |  18 +--
 test/dm/mdio_mux.c                          |  16 +--
 test/dm/ofnode.c                            |  22 ++++
 85 files changed, 508 insertions(+), 631 deletions(-)
Signature · 1 line
2.35.1