Skip to content

nvmet: unique discovery subsystems

Hannes Reinecke linux-nvme 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 6 repliesIn review
  2. v53 patches 13 repliesSuperseded
  3. v43 patches 14 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches2 repliesSuperseded
v23 patches23 repliesSuperseded
v13 patches0 repliesSuperseded

Changes to v5 from the cover letter

- Implement 'expose_discovery_subsys' module option to allow the creation of the standard discovery subsystem via configfs.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4nvmet: make the subsystem type configurabledrivers/nvme/target/configfs.c drivers/nvme/target/discovery.c drivers/nvme/target/nvmet.h+62 -12 replies
2/4nvmet: per-port discovery subsystemdrivers/nvme/target/configfs.c drivers/nvme/target/core.c drivers/nvme/target/discovery.c +1 more+49 -160 replies
3/4nvmet: include all configured ports in the discovery log pagedrivers/nvme/target/discovery.c+44 -92 replies
4/4nvmet: expose discovery subsystemdrivers/nvme/target/configfs.c drivers/nvme/target/core.c drivers/nvme/target/discovery.c+25 -72 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCHv6 0/4] nvmet: unique discovery subsystems

Hi all,

here's my next attempt to support unique discovery subsystems.

As per suggestion from Christoph this patchset allows to have a per-port discovery subsystem. For that a normal NVMe subsystem needs to be created via configfs, the type needs to be changed to 'discovery', and then linked into the port where this discovery subsystem should be visible.

Once that is done the discovery log page output will include all ports into which the same discovery controller is linked.

If the discovery subsystem is unlinked the default behaviour is reinstated.
Additionally a module parameter 'expose_discovery_subsys' is implemented,
which will allow (or, rather, require) the creation of the default discovery subsystem via configfs, too. Once that option is enabled only ports into which a discovery subsystem is linked will be presenting a discovery service; on
other ports a discovery attempt will fail.

As usual, comments and reviews are welcome.

Changes to v5:
- Implement 'expose_discovery_subsys' module option to allow the creation of the standard discovery subsystem via configfs.
Changes to v4:
- Unset disc_subsys pointer when unique discovery subsystem
gets unlinked
- Improve documentation
- Use port count to determine if a subsystem is linked to ports

Changes to v3:
- Rework to use per-port discovery subsystems as suggested by hch

Changes to v2:
- Heavily rework after discussion on the mailing list

Changes to the original submission:
- Include all subsystems in the discovery log output

Hannes Reinecke (4):
nvmet: make the subsystem type configurable
nvmet: per-port discovery subsystem
nvmet: include all configured ports in the discovery log page
nvmet: expose discovery subsystem

 drivers/nvme/target/configfs.c  |  80 ++++++++++++++++++++++-
 drivers/nvme/target/core.c      |  15 ++++-
 drivers/nvme/target/discovery.c | 108 +++++++++++++++++++++++++-------
 drivers/nvme/target/nvmet.h     |   2 +
 4 files changed, 176 insertions(+), 29 deletions(-)
Signature · 1 line
2.29.2