Skip to content

Convert vmcore to use an iov_iter

Baoquan He kexec linux-fsdevel lkml oe-kbuild-all 3 versions – Applied

Status from this message: [merged mm-nonmm-stable] vmcore-convert-copy_oldmem_page-to-take-an-iov_iter.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/23 patches 13 repliesApplied 3/3
  2. v5 posting 1/23 patches 5 repliesSuperseded
  3. v44 patches 8 repliesSuperseded

Changes in v5 from the cover letter

- Add my own Signed-off-by, no code or log change related in this round.

Patches in v5 posting 2/2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3vmcore: Convert copy_oldmem_page() to take an iov_iterarch/arm/kernel/crash_dump.c arch/arm64/kernel/crash_dump.c arch/ia64/kernel/crash_dump.c +9 more+91 -2607 repliesApplied
2/3vmcore: Convert __read_vmcore to use an iov_iterfs/proc/vmcore.c+30 -521 replyApplied
3/3vmcore: Convert read_from_oldmem() to take an iov_iterarch/x86/kernel/crash_dump_64.c fs/proc/vmcore.c include/linux/crash_dump.h+25 -321 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter

Copy the description of v3 cover letter from Willy:
===
For some reason several people have been sending bad patches to fix compiler warnings in vmcore recently. Here's how it should be done. Compile-tested only on x86. As noted in the first patch, s390 should take this conversion a bit further, but I'm not inclined to do that work myself.

V4:
[PATCH v4 0/3] Convert vmcore to use an iov_iter
https://lore.kernel.org/all/20220318093706.161534-1-bhe at redhat.com/T/#u

v3:
[PATCH v3 0/3] Convert vmcore to use an iov_iter
https://lore.kernel.org/all/20211213143927.3069508-1-willy at infradead.org/T/#u

Changelog:
===
v5 RESEND:
- Add my own Signed-off-by, no code or log change related in this round.

v5:
- Rebased on Linus's latest master branch.
- Merge the patch 4 of v4 into patch 2.
v4:
- Append one patch to replace the open code with iov_iter_count(). This is suggested by Al.
- Fix a indentation error by replacing space with tab in arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The rest of patch 1~3 are untouched.
- Add Christopy's Reviewed-by and my Acked-by for patch 1~3.
v3:
- Send the correct patches this time
v2:
- Removed unnecessary kernel-doc
- Included uio.h to fix compilation problems
- Made read_from_oldmem_iter static to avoid compile warnings during the conversion
- Use iov_iter_truncate() (Christoph)

Matthew Wilcox (Oracle) (3):
vmcore: Convert copy_oldmem_page() to take an iov_iter
vmcore: Convert __read_vmcore to use an iov_iter
vmcore: Convert read_from_oldmem() to take an iov_iter

 arch/arm/kernel/crash_dump.c     |  27 +------
 arch/arm64/kernel/crash_dump.c   |  29 +------
 arch/ia64/kernel/crash_dump.c    |  32 +-------
 arch/mips/kernel/crash_dump.c    |  27 +------
 arch/powerpc/kernel/crash_dump.c |  35 ++-------
 arch/riscv/kernel/crash_dump.c   |  26 +------
 arch/s390/kernel/crash_dump.c    |  13 ++--
 arch/sh/kernel/crash_dump.c      |  29 ++-----
 arch/x86/kernel/crash_dump_32.c  |  29 +------
 arch/x86/kernel/crash_dump_64.c  |  48 ++++--------
 fs/proc/vmcore.c                 | 130 +++++++++++++------------------
 include/linux/crash_dump.h       |  19 ++---
 12 files changed, 123 insertions(+), 321 deletions(-)
Signature · 1 line
2.34.1