Skip to content

iotests/207: Filter host fingerprint

Hanna Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iotests.py: Filters for VM.run_job()tests/qemu-iotests/iotests.py+16 -101 reply
2/2iotests/207: Filter host fingerprinttests/qemu-iotests/207 tests/qemu-iotests/207.out+9 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJohn Snow
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] iotests/207: Filter host fingerprint

Hi,

Commit e3296cc796aeaf (“block: print the server key type and fingerprint on failure”) improved the verbosity of our ssh block driver's error messages for fingerprint mismatches. However, iotest 207, which tests such errors, has not been adjusted accordingly.

Since the fingerprint will differ between hosts, we need to filter it (and can’t just statically adjust the reference output). The problem is that the error condition is printed by iotest.py’s VM.run_job(), so we need to pass the filter to that function. Right now, VM.run_job() doesn’t support any filters, though, so patch 1 adds a filter parameter and makes VM.run_job() use it.

Patch 2 then has the fix for iotest 207.

Hanna Reitz (2):
iotests.py: Filters for VM.run_job()
iotests/207: Filter host fingerprint

 tests/qemu-iotests/207        |  7 ++++++-
 tests/qemu-iotests/207.out    |  6 +++---
 tests/qemu-iotests/iotests.py | 26 ++++++++++++++++----------
 3 files changed, 25 insertions(+), 14 deletions(-)
Signature · 1 line
2.35.1