Skip to content

xfs: more shutdown/recovery fixes

Dave Chinner linux-xfs nvdimm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 17 repliesIn review
  2. v26 patches 13 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8xfs: aborting inodes on shutdown may need buffer lockfs/xfs/xfs_icache.c fs/xfs/xfs_inode.c fs/xfs/xfs_inode_item.c +1 more+136 -313 replies
2/8xfs: shutdown in intent recovery has non-intent items in the AILfs/xfs/xfs_log_recover.c+17 -331 reply
3/8xfs: run callbacks before waking waiters in xlog_state_shutdown_callbacksfs/xfs/xfs_log.c+13 -91 reply
4/8xfs: log shutdown triggers should only shut down the logfs/xfs/xfs_log.c fs/xfs/xfs_log_cil.c fs/xfs/xfs_log_recover.c +2 more+33 -182 replies
5/8xfs: xfs_do_force_shutdown needs to block racing shutdownsfs/xfs/xfs_fsops.c fs/xfs/xfs_log.c fs/xfs/xfs_log_priv.h+17 -11 reply
6/8xfs: xfs_trans_commit() path must check for log shutdownfs/xfs/xfs_trans.c+33 -151 reply
7/8xfs: shutdown during log recovery needs to mark the log shutdownfs/xfs/xfs_log.c+10 -81 reply
8/8xfs: drop async cache flushes from CIL commits.fs/xfs/xfs_bio_io.c fs/xfs/xfs_linux.h fs/xfs/xfs_log.c +2 more+25 -937 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongJan KaraChristoph Hellwig
1/8R-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b Reported-and-tested-by R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH 0/8 v3] xfs: more shutdown/recovery fixes

Hi folks,

Here is an updated series of aggregated log fixes for recently discovered shutdown bugs, log recovery issues and performance regressions. See the change log for previous versions of this patchset.

V3 of this patchset contains 8 patches because the extra fix for the previous version (patch 7) and sweeping the async cache flush fix into it (patch 8). There are small changes to comments and commit messages, but otherwise is the same as version 2.

Cheers,

Dave.

Version 3:
- various typo and comment fixes.
- new patch to address a shutdown hang during log recovery (patch 7)
- sweep up fix for async cache flush regressions into the series (patch 8)

Version 2:
- https://lore.kernel.org/linux-xfs/[email protected]/
- rework inode cluster buffer checks in inode item pushing (patch 1)
- clean up comments and separation of inode abort behaviour (p1)
- Fix shutdown callback/log force wakeup ordering issue (p3)
- Fix writeback of aborted, incomplete, unlogged changes during shutdown races (p4-6)

Version 1:
- https://lore.kernel.org/linux-xfs/[email protected]/