Skip to content

bpf: Fix kprobe_multi return probe backtrace

Jiri Olsa bpf lkml netdev 1 version Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"kernel/bpf/verifier.c kernel/trace/bpf_trace.c+1 -210 repliesApplied
2/2bpf: Fix kprobe_multi return probe backtracekernel/trace/bpf_trace.c+37 -300 repliesApplied

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrii NakryikoMasami Hiramatsu
SeriesR-b
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next 0/2] bpf: Fix kprobe_multi return probe backtrace

hi,
Andrii reported that backtraces from kprobe_multi program attached as return probes are not complete and showing just initial entry [1].

Sending the fix together with bpf_get_func_ip inline revert, which is no longer suitable.

thanks,
jirka

---
[1] https://lore.kernel.org/bpf/CAEf4BzZDDqK24rSKwXNp7XL3ErGD4bZa1M6c_c4EvDSt3jrZcg@mail.gmail.com/T/#m8d1301c0ea0892ddf9dc6fba57a57b8cf11b8c51

Jiri Olsa (2):
Revert "bpf: Add support to inline bpf_get_func_ip helper on x86"
bpf: Fix kprobe_multi return probe backtrace

 kernel/bpf/verifier.c    | 21 +--------------------
 kernel/trace/bpf_trace.c | 68 +++++++++++++++++++++++++++++++++++++-------------------------------
 2 files changed, 38 insertions(+), 51 deletions(-)