Skip to content

Remove PCIE root bridge LSI on powernv

Frederic Barrat qemu-devel 2 versions – Applied

Status from this message: Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesApplied
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- addressed comments from Daniel

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2pcie: Don't try triggering a LSI when not definedhw/pci/pcie.c hw/pci/pcie_aer.c+4 -33 replies
2/2ppc/pnv: Remove LSI on the PCIE host bridgehw/pci-host/pnv_phb3.c hw/pci-host/pnv_phb4.c+2 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDaniel Henrique BarbozaMichael S. Tsirkin
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Remove PCIE root bridge LSI on powernv

The powernv8/powernv9/powernv10 machines allocate a LSI for their root port bridge, which is not the case on real hardware. The default root port implementation in qemu requests a LSI. Since the powernv implementation derives from it, that's where the LSI is coming from. This series fixes it, so that the model matches the hardware.

However, the code in hw/pci to handle AER and hotplug events assume a LSI is defined. It tends to assert/deassert a LSI if MSI or MSIX is not enabled. Since we have hardware where that is not true, this patch also fixes a few code paths to check if a LSI is configured before trying to trigger it.

Changes from v1:
- addressed comments from Daniel

Frederic Barrat (2):
pcie: Don't try triggering a LSI when not defined ppc/pnv: Remove LSI on the PCIE host bridge

 hw/pci-host/pnv_phb3.c | 1 +
 hw/pci-host/pnv_phb4.c | 1 +
 hw/pci/pcie.c          | 5 +++--
 hw/pci/pcie_aer.c      | 2 +-
 4 files changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
2.35.1