accel: Fix vCPU memory leaks
Status from this message: Queued to tcg-next.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | cpu: Free cpu->cpu_ases in cpu_address_space_destroy()cpu.c include/ softmmu/ | +13 | 2 replies | |
| 2/13 | target/i386/kvm: Free xsave_buf when destroying vCPUtarget/ | +2 | 1 reply | |
| 3/13 | target/i386/hvf: Free resources when vCPU is destroyedtarget/ | +2 | 1 reply | |
| 4/13 | accel/hvf: Remove pointless assertionaccel/ | +0 | 0 replies | |
| 5/13 | accel/tcg: Init TCG cflags in vCPU thread handleraccel/ accel/ | +5 | 2 replies | |
| 6/13 | accel/tcg: Reorganize tcg_accel_ops_init()accel/ | +8 | 2 replies | |
| 7/13 | accel-ops: Introduce create_vcpu_thread_precheck / postcheck handlersinclude/ softmmu/ | +11 | 1 reply | |
| 8/13 | accel/tcg: Extract rr_create_vcpu_thread_precheck()accel/ accel/ | +8 | 0 replies | |
| 9/13 | accel/all: Extract common_vcpu_thread_create()accel/ accel/ accel/ +14 more | +56 | 2 replies | |
| 10/13 | accel-ops: Introduce common_vcpu_thread_destroy() and .precheck handlerinclude/ softmmu/ | +11 | 1 reply | |
| 11/13 | accel/tcg: Add rr_destroy_vcpu_thread_precheck()accel/ accel/ | +10 | 1 reply | |
| 12/13 | softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread()softmmu/ | +1 | 2 replies | |
| 13/13 | softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()softmmu/ | +1 | 1 reply |
Reviews trailers per patch
3 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Mark Kanda | Richard Henderson |
|---|---|---|---|
| 1/13 | T-b | ||
| 2/13 | T-b | R-b | |
| 3/13 | R-b | ||
| 4/13 | |||
| 5/13 | |||
| 6/13 | R-b | ||
| 7/13 | |||
| 8/13 | |||
| 9/13 | |||
| 10/13 | |||
| 11/13 | |||
| 12/13 | |||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 00/13] accel: Fix vCPU memory leaks
From: Philippe Mathieu-Daudé <[email protected]>
Hi,
This is a respin of Mark 'vCPU hotunplug related memory leaks' v3:
https://lore.kernel.org/qemu-devel/[email protected]/
Instead I refactored to extract the common common_vcpu_thread_create() from all accelerators (except TCG/RR, which requires a special-casing).
Not well tested...
Mark Kanda (3):
cpu: Free cpu->cpu_ases in cpu_address_space_destroy() softmmu/cpus: Free cpu->thread in generic_destroy_vcpu_thread() softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()
Philippe Mathieu-Daudé (10):
target/i386/kvm: Free xsave_buf when destroying vCPU target/i386/hvf: Free resources when vCPU is destroyed accel/hvf: Remove pointless assertion
accel/tcg: Init TCG cflags in vCPU thread handler accel/tcg: Reorganize tcg_accel_ops_init()
accel-ops: Introduce create_vcpu_thread_precheck / postcheck handlers accel/tcg: Extract rr_create_vcpu_thread_precheck() accel/all: Extract common_vcpu_thread_create()
accel-ops: Introduce common_vcpu_thread_destroy() and .precheck
handler
accel/tcg: Add rr_destroy_vcpu_thread_precheck()
accel/accel-softmmu.c | 2 +- accel/dummy-cpus.c | 15 +---------- accel/hvf/hvf-accel-ops.c | 24 +++-------------- accel/kvm/kvm-accel-ops.c | 17 +++--------- accel/qtest/qtest.c | 3 ++- accel/tcg/tcg-accel-ops-mttcg.c | 27 +++---------------- accel/tcg/tcg-accel-ops-mttcg.h | 3 +-- accel/tcg/tcg-accel-ops-rr.c | 44 +++++++++++++++---------------- accel/tcg/tcg-accel-ops-rr.h | 7 +++-- accel/tcg/tcg-accel-ops.c | 22 +++++++++------- accel/xen/xen-all.c | 2 +- cpu.c | 1 + include/exec/cpu-common.h | 7 +++++ include/sysemu/accel-ops.h | 9 ++++++- include/sysemu/cpus.h | 4 +-- softmmu/cpus.c | 40 +++++++++++++++++++++++++--- softmmu/physmem.c | 5 ++++ target/i386/hax/hax-accel-ops.c | 20 ++------------ target/i386/hvf/hvf.c | 2 ++ target/i386/kvm/kvm.c | 2 ++ target/i386/nvmm/nvmm-accel-ops.c | 17 +++--------- target/i386/whpx/whpx-accel-ops.c | 20 +++----------- 22 files changed, 127 insertions(+), 166 deletions(-)
Signature · 1 line
2.35.1