Skip to content

Add dynamic memory allocator support for nolibc

Ammar Faizi lkml llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 6 repliesIn review

Changes in v1 from the cover letter

- Rebase, sync with Paul's tree.
- Add new 3 patches [PATCH 03/11], [PATCH 04/11], [PATCH 05/11].

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11tools/nolibc: x86-64: Update System V ABI document linktools/include/nolibc/arch-x86_64.h+1 -10 replies
2/11tools/nolibc: Remove .global _start from the entry point codetools/include/nolibc/arch-aarch64.h tools/include/nolibc/arch-arm.h tools/include/nolibc/arch-i386.h +3 more+0 -60 replies
3/11tools/nolibc: Replace `asm` with `__asm__`tools/include/nolibc/arch-aarch64.h tools/include/nolibc/arch-arm.h tools/include/nolibc/arch-i386.h +3 more+197 -1972 replies
4/11tools/nolibc: x86-64: Use appropriate register constraints if existtools/include/nolibc/arch-x86_64.h+91 -1114 replies
5/11tools/nolibc: i386: Use appropriate register constraints if existtools/include/nolibc/arch-i386.h+70 -920 replies
6/11tools/nolibc: i386: Implement syscall with 6 argumentstools/include/nolibc/arch-i386.h+23 -00 replies
7/11tools/nolibc/sys: Implement `mmap()` and `munmap()`tools/include/nolibc/sys.h+62 -00 replies
8/11tools/nolibc/types: Implement `offsetof()` and `container_of()` macrotools/include/nolibc/types.h+11 -00 replies
9/11tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()`tools/include/nolibc/stdlib.h+81 -00 replies
10/11tools/nolibc/string: Implement `strnlen()`tools/include/nolibc/string.h+9 -00 replies
11/11tools/include/string: Implement `strdup()` and `strndup()`tools/include/nolibc/string.h+32 -00 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchNick Desaulniers
1/11
2/11R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 00/11] Add dynamic memory allocator support for nolibc

Hi,

This is a patchset to add dynamic memory allocator support for nolibc after 2 RFCs, please review the changes carefully.

There are 3 *new* patches after RFC v2:
Address report from Alviro:
- Replace asm with __asm__.
Address suggestions from David:
- x86-64: Use appropriate register constraints if exist (Suggested by David).
- i386: Use appropriate register constraints if exist.

@@ Changelog:
---
Link RFC v2: https://lore.kernel.org/lkml/[email protected]/
RFC v2 -> v1:
- Rebase, sync with Paul's tree.
- Add new 3 patches [PATCH 03/11], [PATCH 04/11], [PATCH 05/11].

[PATCH 02/11]
- Append Reviewed-by tag from Nick.
- s/Removing/remove/

[PATCH 06/11]
- Use the same pattern for syscall6, regardless using GCC or Clang (comment from David).
- Use appropriate constraints for syscall6 instead of always using register variables (comment from David).

[PATCH 09/11]
- Round up the malloc() allocation to 4096 (comment from David).
- Don't realloc() if we still have enough memory to contain the requested new size (comment from David).
- Fix conflict with getenv() fix (after rebase).

Link RFC v1: https://lore.kernel.org/lkml/[email protected]/
RFC v1 -> RFC v2:
- Add 2 new patches [PATCH 5/8] and [PATCH 7/8].

[PATCH 2/8]
- Remove all .global _start for all build (GCC and Clang) instead of removing all .weak _start for clang build (Comment from Willy).

[PATCH 3/8]
- Fix %ebp saving method. Don't use redzone, i386 doesn't have a redzone (comment from David and Alviro).

[PATCH 6/8]
- Move container_of() and offsetof() macro to types.h with a separate patch (comment from Willy).

[PATCH 8/8]
- Update strdup and strndup implementation, use strlen and strnlen to get the string length first (comment from Willy and Alviro).
- Fix the subject line prefix, it was "tools/include/string: ", it should be "tools/nolibc/string: ".
- Update the commit message.

---
Ammar Faizi (11):
tools/nolibc: x86-64: Update System V ABI document link tools/nolibc: Remove .global _start from the entry point code tools/nolibc: Replace asm with __asm__
tools/nolibc: x86-64: Use appropriate register constraints if exist tools/nolibc: i386: Use appropriate register constraints if exist tools/nolibc: i386: Implement syscall with 6 arguments tools/nolibc/sys: Implement mmap() and munmap() tools/nolibc/types: Implement offsetof() and container_of() macro tools/nolibc/stdlib: Implement malloc(), calloc(), realloc() and free() tools/nolibc/string: Implement strnlen()
tools/include/string: Implement strdup() and strndup()

 tools/include/nolibc/arch-aarch64.h |  73 +++++-----
 tools/include/nolibc/arch-arm.h     |  59 ++++----
 tools/include/nolibc/arch-i386.h    | 188 ++++++++++++-------------
 tools/include/nolibc/arch-mips.h    |  63 +++++----
 tools/include/nolibc/arch-riscv.h   |  75 +++++-----
 tools/include/nolibc/arch-x86_64.h  | 207 +++++++++++++---------------
 tools/include/nolibc/stdlib.h       |  81 +++++++++++
 tools/include/nolibc/string.h       |  41 ++++++
 tools/include/nolibc/sys.h          |  62 +++++++++
 tools/include/nolibc/types.h        |  11 ++
 10 files changed, 515 insertions(+), 345 deletions(-)

base-commit: b3f38ba2d1ccaa4c4b2096a310e7b170ef559d4d

Signature · 1 line
Ammar Faizi