Skip to content

drm/atomic: Atomic Private State debugging

Maxime Ripard dri-devel 3 versions – Applied

Status from this message: Applied to drm/drm-misc (drm-misc-next).

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied
  2. v24 patches 1 replySuperseded
  3. v14 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Reworded the commit message of the first patch
- Printed the state before running atomic_check

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4drm/atomic: Print the state every non-blocking commitdrivers/gpu/drm/drm_atomic.c drivers/gpu/drm/drm_atomic_uapi.c+4 -41 reply
2/4drm/atomic: Add atomic_print_state to private objectsdrivers/gpu/drm/drm_atomic.c include/drm/drm_atomic.h+39 -40 replies
3/4drm/vc4: Constify private state accessorsdrivers/gpu/drm/vc4/vc4_kms.c+4 -30 replies
4/4drm/vc4: Implement atomic_print_state for HVS channel statedrivers/gpu/drm/vc4/vc4_kms.c+17 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel Vetter
1/4R-b
2/4R-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] drm/atomic: Atomic Private State debugging

Hi,

This series adds an atomic_print_state hook for drm_private_obj to ease the debugging of driver-specific sub-classes, and adds one for vc4.

It also changes the call site of drm_atomic_print_new_state to make it more consistent.

Let me know what you think,
Maxime

Changes from v2:
- Reworded the commit message of the first patch
- Printed the state before running atomic_check

Changes from v1:
- Added Daniel tags
- Added drm_private_state documentation
- Fixed unused variable warning
- Removed the drm_atomic_nonblocking_commit() logging

Maxime Ripard (4):
drm/atomic: Print the state every non-blocking commit drm/atomic: Add atomic_print_state to private objects drm/vc4: Constify private state accessors drm/vc4: Implement atomic_print_state for HVS channel state

 drivers/gpu/drm/drm_atomic.c      | 20 ++++++++++++++++++++
 drivers/gpu/drm/drm_atomic_uapi.c |  4 ----
 drivers/gpu/drm/vc4/vc4_kms.c     | 24 +++++++++++++++++++++---
 include/drm/drm_atomic.h          | 27 +++++++++++++++++++++++----
 4 files changed, 64 insertions(+), 11 deletions(-)
Signature · 1 line
2.35.1