Skip to content

aspeed/hace: Support AST2600 HACE

Steven Lee qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 1 replyIn review
  2. v53 patches 2 repliesSuperseded
  3. v43 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v32 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Bug fixes in reconstruct_iov().

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3aspeed/hace: Support HMAC Key Buffer register.hw/misc/aspeed_hace.c include/hw/misc/aspeed_hace.h+8 -00 replies
2/3aspeed/hace: Support AST2600 HACEhw/misc/aspeed_hace.c include/hw/misc/aspeed_hace.h+131 -51 reply
3/3tests/qtest: Add test for Aspeed HACE accumulative modetests/qtest/aspeed_hace-test.c+145 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchThomas HuthJoel StanleyCédric Le Goater
1/3R-b
2/3R-b
3/3A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] aspeed/hace: Support AST2600 HACE

This patch series implements ast2600 hace engine with accumulative mode and unit test against to it.

Verified with following models
- AST2600 with OpenBmc VERSION_ID=2.12.0-dev-660-g4c7b3e692-dirty
- check hash verification in uboot and check whether qemu crashed during openbmc web gui login.
- AST1030 with ASPEED zephyr SDK v1.04
- run hash sha256 command in zephyr shell to verify aspeed hace.

Please help to review.

Thanks,
Steven

Changes in v6:
- Bug fixes in reconstruct_iov().

Steven Lee (3):
aspeed/hace: Support HMAC Key Buffer register. aspeed/hace: Support AST2600 HACE
tests/qtest: Add test for Aspeed HACE accumulative mode

 hw/misc/aspeed_hace.c          | 139 +++++++++++++++++++++++++++++--
 include/hw/misc/aspeed_hace.h  |   5 ++
 tests/qtest/aspeed_hace-test.c | 145 +++++++++++++++++++++++++++++++++
 3 files changed, 284 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1