Skip to content

Add LTRF216A Driver

Shreeya Patel linux-devicetree linux-iio lkml 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest2 patches 1 replyIn review
  2. v92 patches 5 repliesSuperseded
  3. v82 patches 1 replySuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v72 patches6 repliesSuperseded
v62 patches11 repliesSuperseded
v52 patches4 repliesSuperseded
v43 patches19 repliesSuperseded
v33 patches3 repliesSuperseded
v23 patches2 repliesSuperseded
v13 patches12 repliesSuperseded

Changes in v10 from the cover letter

- Handle !CONFIG_PM scenario similar to how other IIO drivers do it.
- Fix kernel test robot warning.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: Document ltrf216a light sensor bindingsDocumentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml+49 -00 replies
2/2iio: light: Add support for ltrf216a sensordrivers/iio/light/Kconfig drivers/iio/light/Makefile drivers/iio/light/ltrf216a.c+549 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringAndy Shevchenko
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/2] Add LTRF216A Driver

This patchset adds support for ltrf216a Ambient Light Sensor and documents the DT bindings for the same.

Changes in v10
- Handle !CONFIG_PM scenario similar to how other IIO drivers do it.
- Fix kernel test robot warning.

Changes in v9
- Add LTRF216A_MAIN_STATUS register in volatile function.
- Update the datasheet link.

Changes in v8
- Add caching mechanism to restore register state after h/w resume.
- Add callback functions and disable locking in regmap config.
- Update mutex comment as per it's current scope in the driver.
- Add Shreeya as author of the driver.
- Make some minor cleanups.

Changes in v7
- Add regmap support.
- Fix runtime power management implementation.
- Fix the ordering of devm and non-devm functions.
- Use DEFINE_RUNTIME_DEV_PM_OPS macro
- Fix the error reported by kernel test robot for bindings.

Changes in v6
- Fix some errors reported by kernel test robot.
- Add protocol details for the datasheet link.
- Remove useless assignments.
- Add unit details for read data delay macro.
- Use pm_sleep_ptr().

Changes in v5
- Add power management support.
- Add reset functionality.
- Use readx_poll_timeout() to get data.
- Cleanup some of the redundant code.
- Update int_time_fac after I2C write is successful.
- Rename mutex to lock.
- Use Reverse Xmas tree pattern for all variable definitions.
- Improve error handling messages and add error codes.
- Add one more MODULE_AUTHOR.
- Remove cleardata which was reading data for infrared light.
- Remove patch for deprecated vendor prefix [PATCH v4 3/3].
- Remove deprecated string from DT binding document.

Changes in v4
- Add more descriptive comment for mutex lock
- Fix mutex locking in read_raw()
- Use i2c_smbus_read_i2c_block_data()

Changes in v3
- Use u16 instead of u8 for int_time_fac
- Reorder headers in ltrf216a.c file
- Remove int_time_mapping table and use int_time_available
- Fix indentation in the bindings file.

Changes in v2
- Add support for 25ms and 50ms integration time.
- Rename some of the macros as per names given in datasheet
- Add a comment for the mutex lock
- Use read_avail callback instead of attributes and set the appropriate _available bit.
- Use FIELD_PREP() at appropriate places.
- Add a constant lookup table for integration time and reg val
- Use BIT() macro for magic numbers.
- Improve error handling at few places.
- Use get_unaligned_le24() and div_u64()
- Use probe_new() callback and devm functions
- Return errors in probe using dev_err_probe()
- Use DEFINE_SIMPLE_DEV_PM_OPS()
- Correct the formula for lux to use 0.45 instead of 0.8
- Add interrupt and power supply property in DT bindings
- Add vendor prefix name as per the alphabetical order.

Shreeya Patel (2):
dt-bindings: Document ltrf216a light sensor bindings
iio: light: Add support for ltrf216a sensor

 .../bindings/iio/light/liteon,ltrf216a.yaml   |  49 ++
 drivers/iio/light/Kconfig                     |  11 +
 drivers/iio/light/Makefile                    |   1 +
 drivers/iio/light/ltrf216a.c                  | 537 ++++++++++++++++++
 4 files changed, 598 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
 create mode 100644 drivers/iio/light/ltrf216a.c
Signature · 1 line
2.30.2