Skip to content

staging: r8188eu: SetHwReg8188EU() cleanups

Michael Straube linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 2 repliesIn review
  2. v19 patches 5 repliesSuperseded

Changes in v2 from the cover letter

Moved some code into functions.
The series is based on todays staging-testing.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8staging: r8188eu: remove HW_VAR_RESP_SIFS from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_wlan_util.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+6 -140 replies
2/8staging: r8188eu: remove HW_VAR_MLME_DISCONNECT from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+16 -150 replies
3/8staging: r8188eu: rename some macros to upper casedrivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/rtl8188e_spec.h+9 -130 replies
4/8staging: r8188eu: remove HW_VAR_ACM_CTRL from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_wlan_util.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+26 -280 replies
5/8staging: r8188eu: remove HW_VAR_RXDMA_AGG_PG_TH from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+21 -221 reply
6/8staging: r8188eu: simplify if-else statementdrivers/staging/r8188eu/core/rtw_mlme.c+4 -101 reply
7/8staging: r8188eu: remove HW_VAR_TX_RPT_MAX_MACID from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/usb_halinit.c +2 more+10 -90 replies
8/8staging: r8188eu: remove HW_VAR_BCN_VALID from SetHwReg8188EU()drivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/rtl8188e_cmd.c drivers/staging/r8188eu/hal/usb_halinit.c +1 more+11 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/8] staging: r8188eu: SetHwReg8188EU() cleanups

This series removes some cases from the function SetHwReg8188EU() and moves the functionality to the callers. This is part of the ongoing effort to get rid of the unwanted hal layer.

Tested on x86_64 with Inter-Tech DMG-02.

v2:
Moved some code into functions.
The series is based on todays staging-testing.

Michael Straube (8):
staging: r8188eu: remove HW_VAR_RESP_SIFS from SetHwReg8188EU()
staging: r8188eu: remove HW_VAR_MLME_DISCONNECT from SetHwReg8188EU()
staging: r8188eu: rename some macros to upper case
staging: r8188eu: remove HW_VAR_ACM_CTRL from SetHwReg8188EU()
staging: r8188eu: remove HW_VAR_RXDMA_AGG_PG_TH from SetHwReg8188EU()
staging: r8188eu: simplify if-else statement
staging: r8188eu: remove HW_VAR_TX_RPT_MAX_MACID from SetHwReg8188EU()
staging: r8188eu: remove HW_VAR_BCN_VALID from SetHwReg8188EU()

 drivers/staging/r8188eu/core/rtw_mlme.c       | 36 ++++++-----
 drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 31 +++++++--
 drivers/staging/r8188eu/core/rtw_wlan_util.c  | 38 +++++++++--
 drivers/staging/r8188eu/hal/rtl8188e_cmd.c    |  5 +-
 drivers/staging/r8188eu/hal/usb_halinit.c     | 63 -------------------
 drivers/staging/r8188eu/include/hal_intf.h    |  5 --
 .../staging/r8188eu/include/rtl8188e_spec.h   | 10 +--
 drivers/staging/r8188eu/include/rtw_mlme.h    |  1 +
 .../staging/r8188eu/include/rtw_mlme_ext.h    |  1 +
 9 files changed, 87 insertions(+), 103 deletions(-)
Signature · 1 line
2.35.1

Read the cover letter in its thread