Skip to content

Evictable fanotify marks

Amir Goldstein linux-fsdevel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest16 patches 2 repliesIn review
  2. v316 patches 8 repliesSuperseded
  3. v216 patches 19 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16inotify: show inotify mask flags in proc fdinfofs/notify/fdinfo.c fs/notify/inotify/inotify.h fs/notify/inotify/inotify_user.c+15 -100 replies
2/16inotify: move control flags from mask to mark flagsfs/notify/fsnotify.c fs/notify/inotify/inotify.h fs/notify/inotify/inotify_fsnotify.c +2 more+45 -260 replies
3/16fsnotify: fix wrong lockdep annotationsfs/notify/mark.c+3 -30 replies
4/16fsnotify: pass flags argument to fsnotify_alloc_group()fs/nfsd/filecache.c fs/notify/dnotify/dnotify.c fs/notify/fanotify/fanotify_user.c +6 more+26 -210 replies
5/16fsnotify: make allow_dups a property of the groupfs/notify/mark.c include/linux/fsnotify_backend.h kernel/audit_fsnotify.c+15 -140 replies
6/16fsnotify: create helpers for group mark_mutex lockfs/notify/fdinfo.c fs/notify/group.c fs/notify/mark.c +1 more+52 -150 replies
7/16inotify: use fsnotify group lock helpersfs/notify/inotify/inotify_user.c+2 -20 replies
8/16audit: use fsnotify group lock helperskernel/audit_tree.c+16 -160 replies
9/16nfsd: use fsnotify group lock helpersfs/nfsd/filecache.c+7 -60 replies
10/16dnotify: use fsnotify group lock helpersfs/notify/dnotify/dnotify.c+7 -60 replies
11/16fsnotify: allow adding an inode mark without pinning inodefs/notify/mark.c include/linux/fsnotify_backend.h+61 -200 replies
12/16fanotify: create helper fanotify_mark_user_flags()fs/notify/fanotify/fanotify.h fs/notify/fdinfo.c+12 -40 replies
13/16fanotify: factor out helper fanotify_mark_update_flags()fs/notify/fanotify/fanotify_user.c+25 -220 replies
14/16fanotify: implement "evictable" inode marksfs/notify/fanotify/fanotify.h fs/notify/fanotify/fanotify_user.c include/uapi/linux/fanotify.h+39 -20 replies
15/16fanotify: use fsnotify group lock helpersfs/notify/fanotify/fanotify_user.c+7 -70 replies
16/16fanotify: enable "evictable" inode marksfs/notify/fanotify/fanotify_user.c include/linux/fanotify.h+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/16] Evictable fanotify marks

Jan,

Following v4 patch set addresses your review comments on v3 [3].

I allowed myself to take the clean you requested for fanotify_mark_update_flags() and recalc argument a bit further. I hope you will like the result.

Thanks,
Amir.

Changes since v3 [3]:
- Drop FSNOTIFY_GROUP_FLAG() macro
- Make ALLOW_DUPS a group flag
- Return recalc by value from fanotify_mark_update_flags()
- Rename some flags arguments to fan_flags
- Update outdated comments and commit message
- Rebased and tested on v5.18-rc3

Changes since v2 [2]:
- Simplify group lock helpers (Jan)
- Move FSNOTIFY_GROUP_NOFS flag to group object (Jan)
- Split patch of fanotify_mark_user_flags() (Jan)
- Fix bug in case of EEXIST
- Drop ioctl for debugging
- Rebased and tested on v5.18-rc1

Changes since v1 [1]:
- Fixes for direct reclaim deadlock
- Add ioctl for direct reclaim test
- Rebrand as FAN_MARK_EVICTABLE
- Remove FAN_MARK_CREATE and allow clearing FAN_MARK_EVICTABLE
- Replace connector proxy_iref with HAS_IREF flag
- Take iref in fsnotify_reclac_mark() rather than on add mark to list
- Remove fsnotify_add_mark() allow_dups/flags argument
- Remove pr_debug() prints

[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]/
[3] https://lore.kernel.org/r/[email protected]/

Amir Goldstein (16):
inotify: show inotify mask flags in proc fdinfo
inotify: move control flags from mask to mark flags
fsnotify: fix wrong lockdep annotations
fsnotify: pass flags argument to fsnotify_alloc_group()
fsnotify: make allow_dups a property of the group
fsnotify: create helpers for group mark_mutex lock
inotify: use fsnotify group lock helpers
audit: use fsnotify group lock helpers
nfsd: use fsnotify group lock helpers
dnotify: use fsnotify group lock helpers
fsnotify: allow adding an inode mark without pinning inode
fanotify: create helper fanotify_mark_user_flags()
fanotify: factor out helper fanotify_mark_update_flags()
fanotify: implement "evictable" inode marks
fanotify: use fsnotify group lock helpers
fanotify: enable "evictable" inode marks

 fs/nfsd/filecache.c                  |  14 ++--
 fs/notify/dnotify/dnotify.c          |  13 +--
 fs/notify/fanotify/fanotify.h        |  12 +++
 fs/notify/fanotify/fanotify_user.c   | 100 +++++++++++++++--------
 fs/notify/fdinfo.c                   |  21 ++---
 fs/notify/fsnotify.c                 |   4 +-
 fs/notify/group.c                    |  32 +++++---
 fs/notify/inotify/inotify.h          |  19 +++++
 fs/notify/inotify/inotify_fsnotify.c |   2 +-
 fs/notify/inotify/inotify_user.c     |  47 ++++++-----
 fs/notify/mark.c                     | 115 ++++++++++++++++++---------
 include/linux/fanotify.h             |   1 +
 include/linux/fsnotify_backend.h     |  67 ++++++++++++----
 include/uapi/linux/fanotify.h        |   1 +
 kernel/audit_fsnotify.c              |   5 +-
 kernel/audit_tree.c                  |  34 ++++----
 kernel/audit_watch.c                 |   2 +-
 17 files changed, 324 insertions(+), 165 deletions(-)
Signature · 1 line
2.35.1