Skip to content

qcow2: Improve refcount structure rebuilding

Hanna Reitz qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v22 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Added patch 3 (didn’t squash this into patch 1, because (a) Eric gave his R-b on 1 as-is, and (b) I ended up retouching rebuild_refcount_structure() as a whole, not just the new helper, so a dedicated patch made more sense)
- In patch 1: Changed assert(reftable_size_changed == true) to just assert(reftable_size_changed)
- In patch 2: In comments, replaced “were” by “was”

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qcow2: Improve refcount structure rebuildingblock/qcow2-refcount.c+235 -970 replies
2/3iotests/108: Test new refcount rebuild algorithmtests/qemu-iotests/108 tests/qemu-iotests/108.out+339 -10 replies
3/3qcow2: Add errp to rebuild_refcount_structure()block/qcow2-refcount.c+19 -141 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] qcow2: Improve refcount structure rebuilding

Hi,

v2 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2022-03/msg01260.html

v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-block/2021-03/msg00651.html

This series fixes the qcow2 refcount structure rebuilding mechanism for when the qcow2 image file doesn’t allow writes beyond the end of file (e.g. because it’s on an LVM block device).

v3:
- Added patch 3 (didn’t squash this into patch 1, because (a) Eric gave his R-b on 1 as-is, and (b) I ended up retouching rebuild_refcount_structure() as a whole, not just the new helper, so a dedicated patch made more sense)
- In patch 1: Changed assert(reftable_size_changed == true) to just assert(reftable_size_changed)
- In patch 2: In comments, replaced “were” by “was”

git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[0002] [FC] 'qcow2: Improve refcount structure rebuilding' 002/3:[0006] [FC] 'iotests/108: Test new refcount rebuild algorithm' 003/3:[down] 'qcow2: Add errp to rebuild_refcount_structure()'

Hanna Reitz (3):
qcow2: Improve refcount structure rebuilding iotests/108: Test new refcount rebuild algorithm
qcow2: Add errp to rebuild_refcount_structure()

 block/qcow2-refcount.c     | 353 ++++++++++++++++++++++++++-----------
 tests/qemu-iotests/108     | 259 ++++++++++++++++++++++++++-
 tests/qemu-iotests/108.out |  81 +++++++++
 3 files changed, 587 insertions(+), 106 deletions(-)
Signature · 1 line
2.35.1