Skip to content

ipmi: add limits on users and messages

[email protected] lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ipmi: Add a limit on the number of users that may use IPMIdrivers/char/ipmi/ipmi_msghandler.c+15 -00 replies
2/4ipmi: Limit the number of message a user may have outstandingdrivers/char/ipmi/ipmi_msghandler.c+21 -02 replies
3/4ipmi: Add a sysfs interface to view the number of usersdrivers/char/ipmi/ipmi_msghandler.c+21 -00 replies
4/4ipmi: Add a sysfs count of total outstanding messages for an interfacedrivers/char/ipmi/ipmi_msghandler.c+29 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] ipmi: add limits on users and messages

I had actually already started working on a set of patches for this, but I've incorporated some of your work.

There were problems with your patches:

* The limits on messages were global, not per-user. This could cause unfairness in the interface.

* The counts were on the BMC, not on the interface. The interface is the right place to put them, as that's where the messages flow through, and it's easier to do.

* Going through all the messages to get the count is kind of inefficient to do on a per-send basis. Keep a count instead.

* The ability to flush messages is a no-go. The IPMI driver guarantees responses and internal kernel users (and external users) rely on that property. A flush could break the watchdog or ACPI. The messages will just have to time out.

This is my proposal for your review.

Thanks,

-corey