Skip to content

drm/msm: Userspace allocated GPU addresses

Rob Clark dri-devel linux-arm-msm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest10 patches 2 repliesIn review
  2. v310 patches 1 replySuperseded
  3. v210 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/msm/gem: Move prototypesdrivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_gem.h+22 -230 replies
2/10drm/msm/gpu: Drop duplicate fence counterdrivers/gpu/drm/msm/adreno/a5xx_gpu.c drivers/gpu/drm/msm/adreno/a6xx_gpu.c drivers/gpu/drm/msm/adreno/adreno_gpu.c +3 more+9 -100 replies
3/10drm/msm/gem: Convert some missed GEM_WARN_ON()sdrivers/gpu/drm/msm/msm_gem_vma.c+5 -51 reply
4/10drm/msm/gem: Split out inuse helperdrivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h drivers/gpu/drm/msm/msm_gem_vma.c+9 -31 reply
5/10drm/msm/gem: Drop PAGE_SHIFT for address space mmdrivers/gpu/drm/msm/adreno/a6xx_gmu.c drivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h +1 more+13 -140 replies
6/10drm/msm: Drop msm_gem_iova()drivers/gpu/drm/msm/msm_fb.c drivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h+14 -240 replies
7/10drm/msm/gem: Rework vma lookup and pindrivers/gpu/drm/msm/msm_gem.c+26 -240 replies
8/10drm/msm/gem: Split vma lookup and pindrivers/gpu/drm/msm/msm_gem.c drivers/gpu/drm/msm/msm_gem.h drivers/gpu/drm/msm/msm_gem_submit.c+44 -420 replies
9/10drm/msm/gem: Add fenced vma unpindrivers/gpu/drm/msm/msm_fence.c drivers/gpu/drm/msm/msm_fence.h drivers/gpu/drm/msm/msm_gem.c +4 more+66 -170 replies
10/10drm/msm: Add a way for userspace to allocate GPU iovadrivers/gpu/drm/msm/adreno/adreno_gpu.c drivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_gem.c +3 more+92 -00 replies

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchDmitry BaryshkovDmitry Osipenko
1/10R-b
2/10
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10
9/10
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/10] drm/msm: Userspace allocated GPU addresses

From: Rob Clark <[email protected]>

The first six paches are various cleanups and simplifications. The next two get rid of redundant vma lookups in the submit and retire paths. Following that, fenced vma lets us indicate a fence value following which the vma is no longer used, which is needed because otherwise userspace could observe the signaled fence prior to retire_submits() finishing. (With userspace allocated GPU addresses userspace is tracking when a buffer is no longer used and it's vma can be deleted.) And finally the last patch adds the new uabi for user- space allocated iova.

v2: Fix inuse check in last patch, split GEM_WARN_ON() conversion to
separate patch, and nits
v3: Fix nested fb prepares in 06/10, return -EBUSY if trying to set
iova on buffer that already has one in 10/10
v4: Fix race condition in 09/10

Rob Clark (10):
drm/msm/gem: Move prototypes
drm/msm/gpu: Drop duplicate fence counter drm/msm/gem: Convert some missed GEM_WARN_ON()s drm/msm/gem: Split out inuse helper drm/msm/gem: Drop PAGE_SHIFT for address space mm drm/msm: Drop msm_gem_iova()
drm/msm/gem: Rework vma lookup and pin drm/msm/gem: Split vma lookup and pin drm/msm/gem: Add fenced vma unpin
drm/msm: Add a way for userspace to allocate GPU iova

 drivers/gpu/drm/msm/adreno/a5xx_gpu.c   |   2 +-
 drivers/gpu/drm/msm/adreno/a6xx_gmu.c   |   2 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c   |   2 +-
 drivers/gpu/drm/msm/adreno/adreno_gpu.c |  14 ++-
 drivers/gpu/drm/msm/msm_drv.c           |  21 ++++
 drivers/gpu/drm/msm/msm_drv.h           |  23 ----
 drivers/gpu/drm/msm/msm_fb.c            |  20 +++-
 drivers/gpu/drm/msm/msm_fence.c         |   6 +-
 drivers/gpu/drm/msm/msm_fence.h         |   3 +
 drivers/gpu/drm/msm/msm_gem.c           | 151 ++++++++++++++----------
 drivers/gpu/drm/msm/msm_gem.h           |  52 +++++++-
 drivers/gpu/drm/msm/msm_gem_submit.c    |  32 ++---
 drivers/gpu/drm/msm/msm_gem_vma.c       |  61 +++++++---
 drivers/gpu/drm/msm/msm_gpu.c           |   8 +-
 drivers/gpu/drm/msm/msm_gpu.h           |   2 +-
 drivers/gpu/drm/msm/msm_ringbuffer.c    |  13 +-
 drivers/gpu/drm/msm/msm_ringbuffer.h    |   1 -
 include/uapi/drm/msm_drm.h              |   3 +
 18 files changed, 277 insertions(+), 139 deletions(-)
Signature · 1 line
2.35.1