Skip to content

extensions: Merge *_DNAT and *_REDIRECT

Phil Sutter netfilter-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 1 replyIn review
  2. v19 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9man: DNAT: Describe shifted port range featureextensions/libxt_DNAT.man+4 -10 replies
2/9Revert "libipt_[SD]NAT: avoid false error about multiple destinations specified"extensions/libip6t_DNAT.c extensions/libip6t_SNAT.c extensions/libipt_DNAT.c +1 more+4 -250 replies
3/9extensions: ipt_DNAT: Merge v1 and v2 parsersextensions/libipt_DNAT.c+111 -1790 replies
4/9extensions: ipt_DNAT: Merge v1/v2 print/save codeextensions/libipt_DNAT.c+46 -650 replies
5/9extensions: ipt_DNAT: Combine xlate functions alsoextensions/libipt_DNAT.c+21 -670 replies
6/9extensions: DNAT: Rename from libipt to libxtextensions/libxt_DNAT.c+0 -00 replies
7/9extensions: Merge IPv4 and IPv6 DNAT targetsextensions/libip6t_DNAT.c extensions/libip6t_DNAT.txlate extensions/libipt_DNAT.txlate +2 more+218 -4680 replies
8/9extensions: Merge REDIRECT into DNATextensions/GNUmakefile.in extensions/libip6t_DNAT.t extensions/libip6t_REDIRECT.c +9 more+204 -3800 replies
9/9extensions: man: Document service name support in DNAT and REDIRECTextensions/libxt_DNAT.man extensions/libxt_REDIRECT.man+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [iptables PATCH v2 0/9] extensions: Merge *_DNAT and *_REDIRECT

Second try, without fancy service name parsing in ranges this time. Instead, mention support for names outside of ranges in extensions man page.

Other changes since v1:
- Fixed for garbage in output when listing multiple DNAT rules (due to missing reinit of a static buffer.
- Drop of last patch revealed a crash bug in service name parser.
- Do not allow service names in ranges' upper boundary.
- More test cases.

Phil Sutter (9):
man: DNAT: Describe shifted port range feature
Revert "libipt_[SD]NAT: avoid false error about multiple destinations
specified"
extensions: ipt_DNAT: Merge v1 and v2 parsers
extensions: ipt_DNAT: Merge v1/v2 print/save code
extensions: ipt_DNAT: Combine xlate functions also
extensions: DNAT: Rename from libipt to libxt
extensions: Merge IPv4 and IPv6 DNAT targets
extensions: Merge REDIRECT into DNAT
extensions: man: Document service name support in DNAT and REDIRECT

 extensions/GNUmakefile.in          |   4 +-
 extensions/libip6t_DNAT.c          | 409 ------------------
 extensions/libip6t_DNAT.t          |   4 +
 extensions/libip6t_DNAT.txlate     |  11 -
 extensions/libip6t_REDIRECT.c      | 170 --------
 extensions/libip6t_REDIRECT.t      |   6 -
 extensions/libip6t_REDIRECT.txlate |   5 -
 extensions/libip6t_SNAT.c          |   9 +-
 extensions/libipt_DNAT.c           | 507 ----------------------
 extensions/libipt_DNAT.t           |   4 +
 extensions/libipt_DNAT.txlate      |  14 -
 extensions/libipt_REDIRECT.c       | 174 --------
 extensions/libipt_REDIRECT.t       |   6 -
 extensions/libipt_REDIRECT.txlate  |   5 -
 extensions/libipt_SNAT.c           |   3 -
 extensions/libxt_DNAT.c            | 650 +++++++++++++++++++++++++++++
 extensions/libxt_DNAT.man          |   7 +-
 extensions/libxt_DNAT.txlate       |  35 ++
 extensions/libxt_REDIRECT.man      |   1 +
 extensions/libxt_REDIRECT.t        |  16 +
 extensions/libxt_REDIRECT.txlate   |  26 ++
 21 files changed, 746 insertions(+), 1320 deletions(-)
 delete mode 100644 extensions/libip6t_DNAT.c
 delete mode 100644 extensions/libip6t_DNAT.txlate
 delete mode 100644 extensions/libip6t_REDIRECT.c
 delete mode 100644 extensions/libip6t_REDIRECT.t
 delete mode 100644 extensions/libip6t_REDIRECT.txlate
 delete mode 100644 extensions/libipt_DNAT.c
 delete mode 100644 extensions/libipt_DNAT.txlate
 delete mode 100644 extensions/libipt_REDIRECT.c
 delete mode 100644 extensions/libipt_REDIRECT.t
 delete mode 100644 extensions/libipt_REDIRECT.txlate
 create mode 100644 extensions/libxt_DNAT.c
 create mode 100644 extensions/libxt_DNAT.txlate
 create mode 100644 extensions/libxt_REDIRECT.t
 create mode 100644 extensions/libxt_REDIRECT.txlate
Signature · 1 line
2.34.1