Skip to content

python: fork qemu.qmp python lib into independent repo

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13pylint hotfixqemu/qmp/legacy.py+0 -20 replies
2/13fork qemu.qmp from qemu.git.gitignore Makefile setup.cfg +1 more+11 -335 replies
3/13update VERSION to 0.0.0a1VERSION+1 -10 replies
4/13update maintainer metadatasetup.cfg+4 -20 replies
5/13update project descriptionsetup.cfg+1 -11 reply
6/13update project URLssetup.cfg+4 -20 replies
7/13add a couple new trove classifierssetup.cfg+2 -01 reply
8/13move README.rst to FILES.rst and updateFILES.rst MANIFEST.in+13 -370 replies
9/13move PACKAGE.rst to README.rst and updateFILES.rst MANIFEST.in PACKAGE.rst +2 more+163 -462 replies
10/13docs: add versioning policy to READMEREADME.rst+21 -02 replies
11/13add LGPLv2+ and GPLv2 LICENSE filesFILES.rst LICENSE LICENSE_GPL2 +5 more+828 -40 replies
12/13update PipfilePipfile Pipfile.lock+195 -1300 replies
13/13remove sub-dependency pins from PipfilePipfile+0 -330 replies

Reviews trailers per patch

5 of 13 patches have a Reviewed-by or Acked-by.

PatchKashyap ChamarthyBeraldo LealDamien Hedde
1/13
2/13R-b
3/13
4/13
5/13R-b
6/13
7/13R-b
8/13
9/13R-b
10/13R-b
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [qemu.qmp PATCH 00/13] python: fork qemu.qmp python lib into independent repo

GitLab: https://gitlab.com/jsnow/qemu.qmp/-/commits/pt2a

Hi, this series is part of an effort to publish the qemu.qmp package on PyPI. It is the second of three phases to complete this work:

(1) Switch the new Async QMP library in to python/qemu/qmp
(2) Fork python/qemu/qmp out into its own repository.
--> (2a) Do the bare minimum to be consistent.
(2b) Add most GitLab CI/CD targets.
(2c) Add Sphinx doc builds, update docs, and publish to GitLab pages. (2d) Add dynamic git versioning and GitLab package builds.
(3) Update qemu.git to install qemu.qmp from PyPI,
and then delete python/qemu/qmp.

This series is not meant to apply to qemu.git, rather -- it's the series that performs the split and would apply to a brand new repository.

I am submitting it to the QEMU mailing list because:

(1) To more broadly announce my intentions, and as reference alongside series #1 and #3 detailed above. It'll be catalogued in the ML archives this way, too.

(2) To ask for permission to become the maintainer of a 'qemu-project/py-qemu.qmp' repository, where I would like to host this subproject.

(3) To ask for review on the README.rst file which details my intended contribution guidelines for this subproject.

(4) To see if there's any feedback on the mechanics of how I forked this subproject.

Review notes / points of interest:

- I use jsnow/qemu.qmp as the repo name throughout the series; that will have to be changed eventually, but for the purposes of prototyping, it was nicer to have a fully working series.

- I'm planning on using gitlab issues and MRs for the subproject.

- The intended versioning paradigm is recorded in patch #10.

- GitLab integration, automatic package builds, and other fancy features are saved for another series. It was getting extremely long, so let's stick to the basics, then add on each feature one at a time.

John Snow (13):
pylint hotfix
fork qemu.qmp from qemu.git
update VERSION to 0.0.0a1
update maintainer metadata
update project description
[FIXME] update project URLs
add a couple new trove classifiers
move README.rst to FILES.rst and update [FIXME] move PACKAGE.rst to README.rst and update
docs: add versioning policy to README
add LGPLv2+ and GPLv2 LICENSE files update Pipfile
remove sub-dependency pins from Pipfile

 .gitignore            |   2 +-
 FILES.rst             |  67 ++++++
 LICENSE               | 481 ++++++++++++++++++++++++++++++++++++++++++
 LICENSE_GPL2          | 339 +++++++++++++++++++++++++++++
 MANIFEST.in           |   3 +-
 Makefile              |  16 +-
 PACKAGE.rst           |  43 ----
 Pipfile               |   4 +-
 Pipfile.lock          | 288 ++++++++++++++-----------
 README.rst            | 268 +++++++++++++++--------
 VERSION               |   2 +-
 qemu/qmp/__init__.py  |   2 +-
 qemu/qmp/legacy.py    |   4 +-
 qemu/qmp/qmp_shell.py |   2 +-
 qemu/qmp/qmp_tui.py   |   2 +-
 setup.cfg             |  43 ++--
 setup.py              |   2 +-
 17 files changed, 1260 insertions(+), 308 deletions(-)
 create mode 100644 FILES.rst
 create mode 100644 LICENSE
 create mode 100644 LICENSE_GPL2
 delete mode 100644 PACKAGE.rst
Signature · 1 line
2.34.1