Skip to content

leds: pca955x: Add HW blink support

Eddie James linux-leds lkml 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 0 repliesNew
  2. v64 patches 0 repliesSuperseded
  3. v54 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches0 repliesSuperseded
v34 patches5 repliesSuperseded
v22 patches4 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v7 from the cover letter

- Fix erroneous return value check of smbus block read

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4leds: pca955x: Refactor with helper functions and renamingdrivers/leds/leds-pca955x.c+24 -260 replies
2/4leds: pca955x: Use pointers to driver data rather than I2C clientdrivers/leds/leds-pca955x.c+27 -340 replies
3/4leds: pca955x: Optimize probe led selectiondrivers/leds/leds-pca955x.c+31 -110 replies
4/4leds: pca955x: Add HW blink supportdrivers/leds/leds-pca955x.c+173 -560 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] leds: pca955x: Add HW blink support

This series adds support for blinking using the PCA955x chip, falling back to software blinking if another LED on the chip is already blinking at a different rate, or if the requested rate isn't representable with the PCA955x.
Also included are some minor clean up and optimization changes that make the HW blinking a bit easier.

Changes since v6:
- Fix erroneous return value check of smbus block read

Changes since v5:
- Use auto-incrementing control register to read all the led selectors at once during initialization

Changes since v4:
- Set duty cycle to fifty percent for blinked LEDs in order to maintain the specified blink rate.

Changes since v3:
- Initialize return value in the blink function
Thanks Dan Carpenter and kernel test robot

Changes since v2:
- Split the cleanup patch
- Prettier dev_err calls
- Include units for blink period and use defined unit translations rather than just a number.
- Use positive conditionals.

Changes since v1:
- Rework the blink function to fallback to software blinking if the period is out of range of the chip's capabilities or if another LED on the chip is already blinking at a different rate.
- Add the cleanup patch

Eddie James (4):
leds: pca955x: Refactor with helper functions and renaming
leds: pca955x: Use pointers to driver data rather than I2C client
leds: pca955x: Optimize probe led selection
leds: pca955x: Add HW blink support

 drivers/leds/leds-pca955x.c | 350 ++++++++++++++++++++++++------------
 1 file changed, 239 insertions(+), 111 deletions(-)
Signature · 1 line
2.31.1