core: add gpiod_request_lines
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest4 patches 2 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | core: add gpiod_request_linesinclude/ lib/ tests/ | +105 | 0 replies | |
| 2/4 | tools: rename inexistent to nonexistenttools/ | +2 | 0 replies | |
| 3/4 | tools: migrate to gpiod_request_linestools/ tools/ tools/ +5 more | +41 | 0 replies | |
| 4/4 | tools: minimize object lifetimestools/ tools/ tools/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [libgpiod v2][PATCH 0/4] core: add gpiod_request_lines
In my review of the CXX bindings I suggested a top-level version of Chip.request_lines(), and possibly a C API version as well, so here is the C version, plus a couple of semi-related tweaks I made along the way.
The first patch adds the gpiod_request_lines().
Patch 3 migrates the appropriate tools.
Patch 4 minimizes the lifetimes of objects in the tools as I've previously seen confusion over how long lived objects need to be. Patch 2 is just a rename cos "inexistent" looks weird to me. Strictly speaking it is fine, but unless there is a problem with using "nonexistent" I would go with the latter.
This series may be require my unsigned values patch.
Cheers,
Kent.
Kent Gibson (4):
core: add gpiod_request_lines
tools: rename inexistent to nonexistent
tools: migrate to gpiod_request_lines
tools: minimize object lifetimes
include/gpiod.h | 15 ++++++++ lib/line-request.c | 17 +++++++++ tests/tests-line-request.c | 73 ++++++++++++++++++++++++++++++++++++++ tools/gpio-tools-test.bats | 4 +-- tools/gpiodetect.c | 2 +- tools/gpiofind.c | 2 +- tools/gpioget.c | 25 +++++++------ tools/gpioinfo.c | 4 +-- tools/gpiomon.c | 16 ++++----- tools/gpioset.c | 18 +++++----- tools/tools-common.c | 50 ++++++++++---------------- tools/tools-common.h | 5 +-- 12 files changed, 164 insertions(+), 67 deletions(-)
Signature · 1 line
2.35.1