net: dsa: mv88e6xxx: Implement offload of matchall for bridged DSA ports
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 4 repliesIn review
- v32 patches 7 repliesSuperseded
- v22 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 1 reply | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: dsa: track whetever bridges have foreign interfaces in theminclude/ net/ net/ | +81 | 1 reply | |
| 2/3 | net: dsa: Add support for offloading tc matchall with drop targetinclude/ include/ net/ +3 more | +264 | 0 replies | |
| 3/3 | net: dsa: mv88e6xxx: Add HW offload support for tc matchall in Marvell switchesdrivers/ | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 net-next 0/3] net: dsa: mv88e6xxx: Implement offload of matchall for bridged DSA ports
Greetings,
This series implements offloading of tc matchall filter to HW for bridged DSA ports.
Background
When using a non-VLAN filtering bridge we want to be able to drop traffic directed to the CPU port so that the CPU doesn't get unnecessary loaded. This is specially important when we have disabled learning on user ports.
A basic sample configuration could be something like this:
br0
/ \swp0 swp1
ip link add dev br0 type bridge stp_state 0 vlan_filtering 0 ip link set swp0 master br0
ip link set swp1 master br0
ip link set swp0 type bridge_slave learning off
ip link set swp1 type bridge_slave learning off
ip link set swp0 up
ip link set swp1 up
ip link set br0 up
After discussions here: https://lore.kernel.org/netdev/YjMo9xyoycXgSWXS@shredder/
it was advised to use tc to set an ingress filter that could then
be offloaded to HW, like so:
tc qdisc add dev br0 clsact
tc filter add dev br0 ingress pref 1 proto all matchall action drop
Another situation that needs to be handled is when there is a foreign interface in the bridge. In this case traffic must reach the bridge, like the setup below.
br0
/ | \
swp0 swp1 veth0Yet another case is when we have ports that are bonded with an foreign interface added to the bridge.
br0
/ \
bond0 veth0
/ \
swp0 swp1These examples highlight the need to evaluate the bridge stack to be able to make the right decision about whetever we can offload this to hw or not.
Limitations
If there is tc rules on a bridge and all the ports leave the bridge and then joins the bridge again, the indirect framwork doesn't seem to reoffload them at join. The tc rules need to be torn down and re-added. This seems to be because of limitations in the tc framework. A fix for this would need another patch-series in itself. However we prepare for when this issue is fixed by registring and deregistring when a dsa_bridge is created/destroyed so it should work when it's solved.
The first patch in this series now include changes done by Vladimir Oltean to cleanup netdev notifier code and check for foreign interfaces. The second part uses the flow indirect framework to setup monitoring of tc qdisc and filters added to a bridge. The last part offloads the matchall filter to HW for Marvell switches.
RFC -> v1: Monitor bridge join/leave and re-evaluate offloading (Vladimir Oltean)
v2: Fix code standard compliance (Jakub Kicinski)
v3: Fix warning from kernel test robot (<[email protected]>)
v4: Check matchall priority (Jakub)
Use boolean type (Vladimir)
Use Vladimirs code for checking foreign interfaces
Drop unused argument (Vladimir)
Add switchdev notifier (Vladimir)
Only call ops when value have changed (Vladimir)
Add error check (Vladimir)
Mattias Forsblad (3):
net: dsa: track whetever bridges have foreign interfaces in them
net: dsa: Add support for offloading tc matchall with drop target
net: dsa: mv88e6xxx: Add HW offload support for tc matchall in Marvell
switches
drivers/net/dsa/mv88e6xxx/chip.c | 17 +- include/net/dsa.h | 15 ++ include/net/switchdev.h | 2 + net/dsa/dsa2.c | 2 + net/dsa/dsa_priv.h | 3 + net/dsa/port.c | 14 ++ net/dsa/slave.c | 321 +++++++++++++++++++++++++++++-- 7 files changed, 361 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.1