Skip to content

qapi/ui: change vnc addresses

Vladimir Sementsov-Ogievskiy qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest3 patches 0 repliesNew

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ui/vnc: refactor arrays of addresses to SocketAddressListui/vnc.c+51 -780 replies
2/3qapi/ui: add 'display-update' command for changing listen addressdocs/about/removed-features.rst include/ui/console.h monitor/qmp-cmds.c +2 more+106 -10 replies
3/3avocado/vnc: add test_change_listentests/avocado/vnc.py+63 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarc-André LureauDaniel P. Berrangé
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] qapi/ui: change vnc addresses

v5: tiny tweaks, add r-bs

Recently our customer requested a possibility to change VNC listen port dynamically.

Happily in Rhel7-based Qemu we already have this possibility: through deprecated "change" qmp command.

But since 6.0 "change" qmp command was removed, with recommendation to use change-vnc-password or blockdev-change-medium instead. Of course, neither of them allow change VNC listen port.

So, let's reimplement the possibility.

Vladimir Sementsov-Ogievskiy (3):
ui/vnc: refactor arrays of addresses to SocketAddressList qapi/ui: add 'display-update' command for changing listen address avocado/vnc: add test_change_listen

 docs/about/removed-features.rst |   3 +-
 qapi/ui.json                    |  65 ++++++++++++++
 include/ui/console.h            |   1 +
 monitor/qmp-cmds.c              |  15 ++++
 ui/vnc.c                        | 152 ++++++++++++++++----------------
 tests/avocado/vnc.py            |  63 +++++++++++++
 6 files changed, 220 insertions(+), 79 deletions(-)
Signature · 1 line
2.35.1