Fix perf bench numa to work with machines having #CPUs > 1K
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 2 repliesApplied
- v24 patches 11 repliesSuperseded
- v14 patches 5 repliesSuperseded
Changes in v3 from the cover letter
Link to the v2 version :
https://lore.kernel.org/all/[email protected]/
- From the v2 version, patch 1 and patch 2 are now part of upstream.
- This v3 version separates patch 3 and patch 4 to address review comments from arnaldo which includes using sysfs__read_str for reading sysfs file and fixing the compilation issues observed in debian
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | tools/perf: Fix perf bench numa testcase to check if CPU used to bind task is onlinetools/ tools/ tools/ | +58 | 0 replies | |
| 2/2 | perf bench: Fix numa bench to fix usage of affinity for machines with #CPUs > 1Ktools/ | +95 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Disha Goel |
|---|---|
| 1/2 | T-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V3 0/2] Fix perf bench numa to work with machines having #CPUs > 1K
The perf benchmark for collections: numa hits failure in system configuration with CPU's more than 1024. These benchmarks uses "sched_getaffinity" and "sched_setaffinity" in the code to work with affinity.
Example snippet from numa benchmark:
<<>>
perf: bench/numa.c:302: bind_to_node: Assertion `!(ret)' failed. Aborted (core dumped)
<<>>
bind_to_node function uses "sched_getaffinity" to save the cpumask. This fails with EINVAL because the default mask size in glibc is 1024
To overcome this 1024 CPUs mask size limitation of cpu_set_t, change the mask size using the CPU_*_S macros ie, use CPU_ALLOC to allocate cpumask, CPU_ALLOC_SIZE for size, CPU_SET_S to set mask bit.
Fix all the relevant places in the code to use mask size which is large enough to represent number of possible CPU's in the system.
This patchset also address a fix for parse_setup_cpu_list function in numa bench to check if input CPU is online before binding task to that CPU. This is to fix failures where, though CPU number is within max CPU, it could happen that CPU is offline. Here, sched_setaffinity will result in failure when using cpumask having that cpu bit set in the mask.
Patch 1 address fix for parse_setup_cpu_list to check if CPU used to bind task is online. Patch 2 has fix for bench numa to work with machines having #CPUs > 1K
Athira Rajeev (2):
tools/perf: Fix perf bench numa testcase to check if CPU used to bind
task is online
perf bench: Fix numa bench to fix usage of affinity for machines with
#CPUs > 1K
Changelog:
v2 -> v3
Link to the v2 version :
https://lore.kernel.org/all/[email protected]/
- From the v2 version, patch 1 and patch 2 are now part of upstream.
- This v3 version separates patch 3 and patch 4 to address review comments from arnaldo which includes using sysfs__read_str for reading sysfs file and fixing the compilation issues observed in debian
tools/perf/bench/numa.c | 136 +++++++++++++++++++++++++++++---------- tools/perf/util/header.c | 51 +++++++++++++++ tools/perf/util/header.h | 1 + 3 files changed, 153 insertions(+), 35 deletions(-)
Signature · 1 line
2.35.1