spl: Use common function for loading/parsing images
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 8 repliesIn review
- v29 patches 7 repliesSuperseded
- v1 RFC7 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- Fix using ffs instead of fls
- Fix using not initializing bl_len when info->filename was NULL
- Fix failing on success
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | spl: Add generic spl_load functioncommon/ include/ | +97 | 2 replies | |
| 2/9 | spl: Convert ext to use spl_loadcommon/ | +17 | 0 replies | |
| 3/9 | spl: Convert fat to spl_loadcommon/ | +8 | 1 reply | |
| 4/9 | spl: Convert mmc to spl_loadcommon/ | +6 | 1 reply | |
| 5/9 | spl: Convert net to spl_loadcommon/ | +5 | 1 reply | |
| 6/9 | spl: Convert nor to spl_loadcommon/ | +6 | 0 replies | |
| 7/9 | spl: Convert semihosting to spl_loadcommon/ | +16 | 0 replies | |
| 8/9 | spl: Convert spi to spl_loadcommon/ | +7 | 2 replies | |
| 9/9 | spl: spi: Consolidate spi_load_image_os into spl_spi_load_imagecommon/ | +33 | 0 replies |
Reviews trailers per patch
7 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Stefan Roese | Tom Rini |
|---|---|---|
| 1/9 | R-b | |
| 2/9 | R-b | |
| 3/9 | R-b | T-b |
| 4/9 | R-b | T-b |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | ||
| 8/9 | R-b | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/9] spl: Use common function for loading/parsing images
This series adds support for loading all image types (Legacy, FIT (with and without LOAD_FIT_FULL), and i.MX) to the MMC, SPI, NOR, NET, FAT, and EXT load methods. It does this by introducing a helper function which handles the minutiae of invoking the proper parsing function, and reading the rest of the image.
Hopefully, this will make it easier for load methods to support all image types that U-Boot supports, without having undocumented unsupported image types. I applied this to several loaders which were invoking spl_load_simple_fit and/or spl_parse_image_header, but I did not use it with others (e.g. DFU/RAM) which had complications in the mix.
Here's some bloat-o-meter for j7200_evm_a72_defconfig with ext4 support enabled:
add/remove: 1/0 grow/shrink: 2/4 up/down: 224/-236 (-12)
Function old new delta spl_load - 176 +176 spl_fit_read 60 104 +44 spl_load_image_ext 364 368 +4 spl_nor_load_image 120 108 -12 spl_spi_load_image 280 228 -52 spl_load_image_fat 320 264 -56 spl_mmc_load 716 600 -116
Total: Before=264556, After=264544, chg -0.00%
ext4 support is +48 bytes, because the original image support was so bare-bones (just legacy/raw images). For most boards with a few load methods (where one of them isn't ext4), this series should be no bloat or a net negative. However, in the worst case this series will add 150-180 bytes.
I have only tested EXT and MMC raw loaders. Please try booting your favorite board with NOR/SPI flash or SPI falcon mode.
Changes in v3:
- Fix using ffs instead of fls
- Fix using not initializing bl_len when info->filename was NULL
- Fix failing on success
Changes in v2:
- Use reverse-xmas-tree style for locals in spl_simple_read. This is not complete, since overhead depends on bl_mask.
- Convert semihosting as well
- Consolidate spi_load_image_os into spl_spi_load_image
Sean Anderson (9):
spl: Add generic spl_load function
spl: Convert ext to use spl_load
spl: Convert fat to spl_load
spl: Convert mmc to spl_load
spl: Convert net to spl_load
spl: Convert nor to spl_load
spl: Convert semihosting to spl_load
spl: Convert spi to spl_load
spl: spi: Consolidate spi_load_image_os into spl_spi_load_image
common/spl/spl.c | 68 ++++++++++++++++++ common/spl/spl_ext.c | 24 +++++-- common/spl/spl_fat.c | 40 +++-------- common/spl/spl_mmc.c | 73 ++----------------- common/spl/spl_net.c | 24 ++----- common/spl/spl_nor.c | 35 ++-------- common/spl/spl_semihosting.c | 39 +++++------ common/spl/spl_spi.c | 131 ++++++++++------------------------- include/spl.h | 30 +++++++- 9 files changed, 193 insertions(+), 271 deletions(-)
Signature · 1 line
2.35.1.1320.gc452695387.dirty