Skip to content

RFC Add sysctl entry for controlling crash_kexec_post_notifiers

Alejandro Jimenez linux-doc linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiersDocumentation/admin-guide/sysctl/kernel.rst include/uapi/linux/sysctl.h kernel/sysctl.c+16 -01 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchStephen Brennan
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/1] Add sysctl entry for controlling crash_kexec_post_notifiers

I noticed that in contrast to other kernel core parameters (e.g. kernel.panic, kernel.panic_on_warn, kernel.panic_print) crash_kexec_post_notifiers is not available as a sysctl tunable. I am aware that because it is a kernel core parameter, there is already an entry under:

/sys/module/kernel/parameters/crash_kexec_post_notifiers

and that allows us to read/modify it at runtime. However, I thought it should also be available via sysctl, since users that want to read/set this value at runtime might look there first.

I believe there is an ongoing effort to clean up kernel/sysctl.c, but it wasn't clear to me if this entry (and perhaps the other panic related entries too) should be placed on kernel/panic.c. I wanted to verify first that this change would be welcomed before doing additional refactoring work.

I'd appreciate any comments or suggestions.

Thank you,
Alejandro

Alejandro Jimenez (1):
kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers

 Documentation/admin-guide/sysctl/kernel.rst | 8 ++++++++
 include/uapi/linux/sysctl.h                 | 1 +
 kernel/sysctl.c                             | 7 +++++++
 3 files changed, 16 insertions(+)
Signature · 1 line
2.34.1