Skip to content

staging: r8188eu: remove GetHalDefVar8188EUsb()

Michael Straube linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v15 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- remove dead code first
- use better function names
- make one function static

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: r8188eu: cur_ant is set but never useddrivers/staging/r8188eu/core/rtw_mlme.c+0 -70 replies
2/4staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIVdrivers/staging/r8188eu/core/rtw_cmd.c drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h+8 -70 replies
3/4staging: r8188eu: remove HAL_DEF_CURRENT_ANTENNAdrivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/hal/usb_halinit.c +2 more+13 -70 replies
4/4staging: r8188eu: remove GetHalDefVar8188EUsb()drivers/staging/r8188eu/hal/usb_halinit.c drivers/staging/r8188eu/include/hal_intf.h drivers/staging/r8188eu/os_dep/ioctl_linux.c+1 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] staging: r8188eu: remove GetHalDefVar8188EUsb()

This series removes the function GetHalDefVar8188EUsb(). This is part of the ongoing effort to get rid of the unwanted hal layer.

Tested on x86_64 with Inter-Tech DMG-02.

v2:
- remove dead code first
- use better function names
- make one function static

Michael Straube (4):
staging: r8188eu: cur_ant is set but never used
staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV
staging: r8188eu: remove HAL_DEF_CURRENT_ANTENNA
staging: r8188eu: remove GetHalDefVar8188EUsb()

 drivers/staging/r8188eu/core/rtw_cmd.c       | 11 ++++++++---
 drivers/staging/r8188eu/core/rtw_mlme.c      | 19 ++++++++++---------
 drivers/staging/r8188eu/core/rtw_mlme_ext.c  |  2 +-
 drivers/staging/r8188eu/hal/usb_halinit.c    | 20 --------------------
 drivers/staging/r8188eu/include/hal_intf.h   |  3 ---
 drivers/staging/r8188eu/include/rtw_mlme.h   |  2 ++
 drivers/staging/r8188eu/os_dep/ioctl_linux.c |  8 +-------
 7 files changed, 22 insertions(+), 43 deletions(-)
Signature · 1 line
2.35.1

Read the cover letter in its thread