Skip to content

iommu/amd: Add multiple PCI segments support

Vasant Hegde via iommu linux-iommu 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest35 patches 7 repliesIn review
  2. v237 patches 15 repliesSuperseded
  3. v1 posting 2/237 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 posting 1/215 of 37 patches1 replySuperseded

Changes in v3 from the cover letter

- Addressed Joerg's review comments
- Fixed typo in patch 1 subject
- Fixed few minor things in patch 2
- Merged patch 27 - 29 into one patch
- Added new macros to get seg and devid from sbdf
- Patch 32 : Extend devid to 32bit and added new macro.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35iommu/amd: Update struct iommu_dev_data definitiondrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/iommu.c+20 -140 replies
2/35iommu/amd: Introduce pci segment structuredrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+68 -20 replies
3/35iommu/amd: Introduce per PCI segment device tabledrivers/iommu/amd/amd_iommu.h drivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c +1 more+47 -20 replies
4/35iommu/amd: Introduce per PCI segment rlookup tabledrivers/iommu/amd/amd_iommu.h drivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c +1 more+79 -00 replies
5/35iommu/amd: Introduce per PCI segment irq_lookup_tabledrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+33 -00 replies
6/35iommu/amd: Introduce per PCI segment dev_data_listdrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+14 -110 replies
7/35iommu/amd: Introduce per PCI segment old_dev_tbl_cpydrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+70 -450 replies
8/35iommu/amd: Introduce per PCI segment alias_tabledrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+64 -250 replies
9/35iommu/amd: Introduce per PCI segment unity map listdrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+34 -170 replies
10/35iommu/amd: Introduce per PCI segment last_bdfdrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+45 -270 replies
11/35iommu/amd: Introduce per PCI segment device table sizedrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+13 -80 replies
12/35iommu/amd: Introduce per PCI segment alias table sizedrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+6 -20 replies
13/35iommu/amd: Introduce per PCI segment rlookup table sizedrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c+9 -50 replies
14/35iommu/amd: Convert to use per PCI segment irq_lookup_tabledrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+23 -340 replies
15/35iommu/amd: Convert to use rlookup_amd_iommu helper functiondrivers/iommu/amd/iommu.c+38 -260 replies
16/35iommu/amd: Update irq_remapping_alloc to use IOMMU lookup helper functiondrivers/iommu/amd/iommu.c+10 -50 replies
17/35iommu/amd: Introduce struct amd_ir_data.iommudrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/iommu.c+16 -190 replies
18/35iommu/amd: Update amd_irte_ops functionsdrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/iommu.c+24 -330 replies
19/35iommu/amd: Update alloc_irq_table and alloc_irq_indexdrivers/iommu/amd/iommu.c+9 -170 replies
20/35iommu/amd: Convert to use per PCI segment rlookup_tabledrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+11 -360 replies
21/35iommu/amd: Update set_dte_entry and clear_dte_entrydrivers/iommu/amd/iommu.c+11 -80 replies
22/35iommu/amd: Update iommu_ignore_devicedrivers/iommu/amd/iommu.c+3 -30 replies
23/35iommu/amd: Update dump_dte_entrydrivers/iommu/amd/iommu.c+4 -40 replies
24/35iommu/amd: Update set_dte_irq_entrydrivers/iommu/amd/iommu.c+7 -60 replies
25/35iommu/amd: Update (un)init_device_table_dma()drivers/iommu/amd/init.c+20 -70 replies
26/35iommu/amd: Update set_dev_entry_bit() and get_dev_entry_bit()drivers/iommu/amd/amd_iommu.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+41 -220 replies
27/35iommu/amd: Remove global amd_iommu_[dev_table/alias_table/last_bdf]drivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+27 -950 replies
28/35iommu/amd: Flush upto last_bdf onlydrivers/iommu/amd/iommu.c+6 -30 replies
29/35iommu/amd: Introduce get_device_sbdf_id() helper functiondrivers/iommu/amd/amd_iommu.h drivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/iommu.c+38 -290 replies
30/35iommu/amd: Include PCI segment ID when initialize IOMMUdrivers/iommu/amd/amd_iommu.h drivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/init.c +1 more+35 -330 replies
31/35iommu/amd: Specify PCI segment ID when getting pci devicedrivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+14 -110 replies
32/35iommu/amd: Add PCI segment support for ivrs_[ioapic/hpet/acpihid] commandsDocumentation/admin-guide/kernel-parameters.txt drivers/iommu/amd/init.c+52 -260 replies
33/35iommu/amd: Print PCI segment ID in error log messagesdrivers/iommu/amd/init.c drivers/iommu/amd/iommu.c+23 -230 replies
34/35iommu/amd: Update device_state structure to include PCI seg IDdrivers/iommu/amd/iommu_v2.c+24 -340 replies
35/35iommu/amd: Update amd_iommu_fault structure to include PCI seg IDdrivers/iommu/amd/amd_iommu_types.h drivers/iommu/amd/iommu.c drivers/iommu/amd/iommu_v2.c+7 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/35] iommu/amd: Add multiple PCI segments support

Newer AMD systems can support multiple PCI segments, where each segment contains one or more IOMMU instances. However, an IOMMU instance can only support a single PCI segment.

Current code assumes a system contains only one PCI segment (segment 0) and creates global data structures such as device table, rlookup table, etc.

This series introduces per-PCI-segment data structure, which contains device table, alias table, etc. For each PCI segment, all IOMMUs share the same data structure. The series also makes necessary code adjustment and logging enhancements. Finally it removes global data structures like device table, alias table, etc.

In case of system w/ single PCI segment (e.g. PCI segment ID is zero), IOMMU driver allocates one PCI segment data structure, which will be shared by all IOMMUs.

Patch 1 updates struct iommu_dev_data definition.

Patch 2 - 13 introduce new PCI segment structure and allocate per data structures, and introduce the amd_iommu.pci_seg pointer to point to the corresponded pci_segment structure. Also, we have introduced a helper function rlookup_amd_iommu() to reverse-lookup each iommu for a particular device.

Patch 14 - 27 adopt to per PCI segment data structure and removes global data structure.

Patch 28 fixes flushing logic to flush upto last_bdf.

Patch 29 - 35 convert usages of 16-bit PCI device ID to include 16-bit segment ID.

Changes from v2 -> v3:
- Addressed Joerg's review comments
- Fixed typo in patch 1 subject
- Fixed few minor things in patch 2
- Merged patch 27 - 29 into one patch
- Added new macros to get seg and devid from sbdf
- Patch 32 : Extend devid to 32bit and added new macro.

v2 patchset : https://lore.kernel.org/linux-iommu/[email protected]/T/#t

Changes from v1 -> v2:
- Updated patch 1 to include dev_is_pci() check

v1 patchset : https://lore.kernel.org/linux-iommu/[email protected]/T/#t

Changes from RFC -> v1:
- Rebased patches on top of iommu/next tree.
- Update struct iommu_dev_data definition
- Updated few log message to print segment ID
- Fix smatch warnings

RFC patchset : https://lore.kernel.org/linux-iommu/[email protected]/T/#t

Regards,
Vasant

Suravee Suthikulpanit (20):
iommu/amd: Introduce per PCI segment device table
iommu/amd: Introduce per PCI segment rlookup table
iommu/amd: Introduce per PCI segment old_dev_tbl_cpy iommu/amd: Introduce per PCI segment alias_table
iommu/amd: Convert to use rlookup_amd_iommu helper function iommu/amd: Update irq_remapping_alloc to use IOMMU lookup helper function iommu/amd: Introduce struct amd_ir_data.iommu
iommu/amd: Update amd_irte_ops functions
iommu/amd: Update alloc_irq_table and alloc_irq_index iommu/amd: Update set_dte_entry and clear_dte_entry
iommu/amd: Update iommu_ignore_device
iommu/amd: Update dump_dte_entry
iommu/amd: Update set_dte_irq_entry
iommu/amd: Update (un)init_device_table_dma()
iommu/amd: Update set_dev_entry_bit() and get_dev_entry_bit() iommu/amd: Remove global amd_iommu_[dev_table/alias_table/last_bdf] iommu/amd: Introduce get_device_sbdf_id() helper function iommu/amd: Include PCI segment ID when initialize IOMMU iommu/amd: Specify PCI segment ID when getting pci device iommu/amd: Add PCI segment support for ivrs_[ioapic/hpet/acpihid] commands

Vasant Hegde (15):
iommu/amd: Update struct iommu_dev_data definition iommu/amd: Introduce pci segment structure
iommu/amd: Introduce per PCI segment irq_lookup_table iommu/amd: Introduce per PCI segment dev_data_list iommu/amd: Introduce per PCI segment unity map list iommu/amd: Introduce per PCI segment last_bdf iommu/amd: Introduce per PCI segment device table size iommu/amd: Introduce per PCI segment alias table size iommu/amd: Introduce per PCI segment rlookup table size iommu/amd: Convert to use per PCI segment irq_lookup_table iommu/amd: Convert to use per PCI segment rlookup_table iommu/amd: Flush upto last_bdf only
iommu/amd: Print PCI segment ID in error log messages iommu/amd: Update device_state structure to include PCI seg ID iommu/amd: Update amd_iommu_fault structure to include PCI seg ID

 .../admin-guide/kernel-parameters.txt         |  34 +-
 drivers/iommu/amd/amd_iommu.h                 |  13 +-
 drivers/iommu/amd/amd_iommu_types.h           | 133 +++-
 drivers/iommu/amd/init.c                      | 687 +++++++++++-------
 drivers/iommu/amd/iommu.c                     | 563 ++++++++------
 drivers/iommu/amd/iommu_v2.c                  |  67 +-
 drivers/iommu/amd/quirks.c                    |   4 +-
 7 files changed, 904 insertions(+), 597 deletions(-)
Signature · 5 lines
2.27.0
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu