Skip to content

usb: typec: ucsi: Role swapping fixes

Heikki Krogerus linux-usb stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: typec: ucsi: Fix reuse of completion structuredrivers/usb/typec/ucsi/ucsi.c+4 -00 replies
2/2usb: typec: ucsi: Fix role swappingdrivers/usb/typec/ucsi/ucsi.c+13 -70 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJack PhamJia-Ju Bai
1/2Reported-and-suggested-by
2/2Reported-and-tested-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/2] usb: typec: ucsi: Role swapping fixes

Hi,

It appears these role swapping routines have been broken for a while. The role swap UCSI commands always actually did work, and the roles were most likely always swapped, but these operations just always appeared to fail because of these bugs.

I'm guessing that has kept the problem hidden. Nobody cared about the return values from these operations. It was enough that the roles were swapped in the end.

thanks,

Heikki Krogerus (2):
usb: typec: ucsi: Fix reuse of completion structure
usb: typec: ucsi: Fix role swapping

 drivers/usb/typec/ucsi/ucsi.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
Signature · 1 line
2.35.1