Skip to content

throttle-groups: use QEMU_CLOCK_REALTIME

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block/throttle-groups: use QEMU_CLOCK_REALTIME for qtest tooblock/throttle-groups.c+0 -42 replies
2/2iotests: add throttle testtests/qemu-iotests/tests/throttle tests/qemu-iotests/tests/throttle.out+50 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH for-7.1 0/2] throttle-groups: use QEMU_CLOCK_REALTIME

Hi all!

Honestly, I don't know why QEMU_CLOCK_VIRTUAL is used here. Comment say that that's specially for throttle tests, but the simple test (patch 02) just hangs because QEMU_CLOCK_VIRTUAL clock just doesn't tick in this environment.. And if we change the clock to QEMU_CLOCK_REALTIME, new test works, and old tests work as well.

What the relation between QEMU_CLOCK_VIRTUAL, qtest and throttle? This code is here since "throttle: Add throttle group support" of 2015..

Vladimir Sementsov-Ogievskiy (2):
block/throttle-groups: use QEMU_CLOCK_REALTIME for qtest too
iotests: add throttle test

 block/throttle-groups.c               |  4 ---
 tests/qemu-iotests/tests/throttle     | 50 +++++++++++++++++++++++++++
 tests/qemu-iotests/tests/throttle.out |  0
 3 files changed, 50 insertions(+), 4 deletions(-)
 create mode 100755 tests/qemu-iotests/tests/throttle
 create mode 100644 tests/qemu-iotests/tests/throttle.out
Signature · 1 line
2.35.1